Allow users to create custom aliases of their choosing #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Resolves swapagarwal#5 * Add an additional optional param called :alias to allow users to pass in a custome key for the url to be saved with. * Throw a 500 error is key already exists in the system.
swapagarwal
requested changes
Nov 11, 2017
|
|
||
| if custom_key | ||
| key = custom_key | ||
| halt 500, 'Duplicate Key' if Link.get(key) |
There was a problem hiding this comment.
4xx seems to be more appropriate here. Let's think on what's the best status code to return in this use-case. What about 409?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in a custom key for the url to be saved with.