Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: feat: add Dark mode #615

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

WIP: feat: add Dark mode #615

wants to merge 12 commits into from

Conversation

tsonge
Copy link
Contributor

@tsonge tsonge commented Jun 2, 2020

  • I've checked that this isn't a new swag opportunity proposal.
  • I've checked that this isn't a duplicate pull request.

Fixes #106

Here is my attempt at adding a dark mode toggle feature. Open to feedback!

How it looks right now:

Screen Shot 2020-06-05 at 7 56 27 PM

TODOs:

  • Implement a nice dark mode toggle button.
  • Set text to be dark in Selectr input drop down (tags filter input)
  • Find out how to style iframe upscribe newsletter when CORS is disabled
  • Use localStorage to remember user preference accross site visits
  • switch colors of 'check it out' blue button when dark mode (improve contrast)

@tsonge
Copy link
Contributor Author

tsonge commented Jun 6, 2020

@aslafy-z @vikaspotluri123 What do you guys think? I've done most of the things I wanted to do.

I could not manage to style the font color in the upscribe newsletter section since it is within an <iframe> element, with CORS disabled. Do you know how to fix that?

@aslafy-z aslafy-z changed the title WIP Dark mode WIP: feat: add Dark mode Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Dark Mode 🌚
1 participant