New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hacktoberfest 2020 #667
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to get a review (@aslafy-z) of my suggestions before requesting changes 😄
data.json
Outdated
@@ -170,6 +170,15 @@ | |||
"dateAdded": "2018-02-18T07:48:58.000Z", | |||
"tags": ["clothing", "hacktoberfest", "expired", "stickers"] | |||
}, | |||
{ | |||
"name": "DigitalOcean", | |||
"difficulty": "medium", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this should be merged with the previous opportunity (Hacktoberfest 2019) 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this is taking again in 2020, and the previous ones is expired, so I suggest there is no need to merge with previous opportunity 2019 version. So, I added one more block in json file.😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hacktoberfest 2018 had its own entry also. I guess we should merge or in few years we'll get overwhelmed by these opportunities :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah True! Then Shall I remove previous ones and make it as only one, so that next coming entries will replace this. And we'll not get overwhelmed : )
data.json
Outdated
"difficulty": "medium", | ||
"description": "Make four Pull Requests (PRs) between October 1–31 in any time zone, and earn a limited edition T-shirt!", | ||
"reference": "https://hacktoberfest.digitalocean.com/", | ||
"image": "https://embed-fastly.wistia.com/deliveries/49bd387c40e2c5aada92abdf973bc46d.webp?image_crop_resized=1920x1080", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might also try this image: https://hacktoberfest.digitalocean.com/HF-full-logo.svg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah sure!
@Sudhee-bsp Ping. |
Didn't get you @swapagarwal ! |
@Sudhee-bsp Can you do the requested changes? We'd like to merge this before Hacktoberfest starts! 😇 |
Sure, ON it! ✌ |
I have merged into the previous Fests of Hacktober. And made requested changes by @swapagarwal and @vikaspotluri123 . Waiting for merging PR :) |
Thank you @Sudhee-bsp! It's live at https://devswag.io |
closes #665
Added new swag entry from this issue with supporting links and images.