Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bugs on error message and refactored codes #1138

Merged
merged 1 commit into from Nov 4, 2023
Merged

fixed bugs on error message and refactored codes #1138

merged 1 commit into from Nov 4, 2023

Conversation

avelynhc
Copy link
Contributor

@avelynhc avelynhc commented Nov 2, 2023

πŸ› οΈ Fixes Issue #1137

πŸ‘¨β€πŸ’» Changes proposed and Brief Description

  • fixed bug of error message not displaying second time after success by adding a try and catch block. In the catch block, new method showErrorMessage was implemented to display an error message to user again
  • removed repetitive codes and create a method, showWeatherImage
  • removed unused variables
  • changed var to either let or const
  • changed == to === for comparison

βœ… Check List (Check all the applicable boxes)

  • My code doesn't break any part of the project
  • This PR does not contain plagiarized content.
  • My Addition/Changes works properly and matches the overall repo pattern.
  • The title of my pull request is a short description of the requested changes.

πŸ“„ Note to reviewers

Let me know if you need me to change anything. Thank you!

πŸ“· Screenshots

  1. when user does not enter anything
Screenshot 2023-11-02 at 11 49 39 AM

2.when user enters a correct city
Screenshot 2023-11-02 at 11 49 49 AM

3.when user enters an incorrect city again
Screenshot 2023-11-02 at 11 49 58 AM

Copy link

netlify bot commented Nov 2, 2023

βœ… Deploy Preview for 30daysofjs ready!

Name Link
πŸ”¨ Latest commit 81d7ee6
πŸ” Latest deploy log https://app.netlify.com/sites/30daysofjs/deploys/6543c66190deaf000897940a
😎 Deploy Preview https://deploy-preview-1138--30daysofjs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@avelynhc
Copy link
Contributor Author

avelynhc commented Nov 2, 2023

@swapnilsparsh Hi, I just pushed the pr. Please kindly review the pr and let me know if you need anything else. Thank you!

@swapnilsparsh swapnilsparsh merged commit 68e83f3 into swapnilsparsh:master Nov 4, 2023
4 checks passed
@swapnilsparsh
Copy link
Owner

@avelynhc Thanks for your contribution! Excited for more in the future! πŸ₯‚

@avelynhc avelynhc deleted the issue-1137 branch November 5, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants