Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project description placeholder is added #1413

Merged
merged 17 commits into from
May 29, 2024

Conversation

Rupa-Rd
Copy link
Contributor

@Rupa-Rd Rupa-Rd commented May 16, 2024

πŸ› οΈ Fixes Issue (Number)

Closes #1199

πŸ‘¨β€πŸ’» Changes proposed and Brief Description

Project description placeholder is added for each project (up-to date). Whenever the user hovers their mouse over the project card, the project description will be shown by fading the background image.

βœ… Check List (Check all the applicable boxes)

  • My code doesn't break any part of the project
  • This PR does not contain plagiarized content.
  • My Addition/Changes works properly and matches the overall repo pattern.
  • The title of my pull request is a short description of the requested changes.

πŸ“„ Note to reviewers

I added only the placeholders for the project description.

πŸ“· Screenshots

screen-capture (22)

Copy link

netlify bot commented May 16, 2024

βœ… Deploy Preview for 30daysofjs ready!

Name Link
πŸ”¨ Latest commit e660b2c
πŸ” Latest deploy log https://app.netlify.com/sites/30daysofjs/deploys/66571874804fa60008ec8cf4
😎 Deploy Preview https://deploy-preview-1413--30daysofjs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@swapnilsparsh swapnilsparsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I hover then on whole project image the description is showing then how will I open that project ?

@Rupa-Rd
Copy link
Contributor Author

Rupa-Rd commented May 18, 2024

If I hover then on whole project image the description is showing then how will I open that project ?

I apologize for not noticing that issue.
Can you check my commits now? The link for the Github repo and website can be accessed now.

Copy link
Owner

@swapnilsparsh swapnilsparsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just remove the lorem ispum and use correct description.

@Rupa-Rd
Copy link
Contributor Author

Rupa-Rd commented May 20, 2024

Looks good just remove the lorem ispum and use correct description.

Sure, I will change it with correct project description.
Since I've exams this week, I would like to take few days to complete this. I'll submit a PR by sunday.
Thank you!.

@swapnilsparsh
Copy link
Owner

@Rupa-Rd just make sure all descriptions are of same length and not more than 3 lines.

@Rupa-Rd
Copy link
Contributor Author

Rupa-Rd commented May 28, 2024

I apologize for the later commits.
@swapnilsparsh , could you check it now?
I added the descriptions for all projects.

@swapnilsparsh
Copy link
Owner

@Rupa-Rd Please make it consistent across every project
image

@swapnilsparsh swapnilsparsh merged commit b49157a into swapnilsparsh:master May 29, 2024
4 checks passed
@swapnilsparsh
Copy link
Owner

@Rupa-Rd Thank you for contributing to this repo. Looking forward for more πŸš€

@swapnilsparsh swapnilsparsh added gssoc GirlScript Summer of Code 2024 level3 Hard labels May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GirlScript Summer of Code 2024 level3 Hard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Title: Adding Project description to the listed projects
2 participants