Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Functionality of Manual Selection of City/Country #64

Merged
merged 3 commits into from
Oct 6, 2021
Merged

Added Functionality of Manual Selection of City/Country #64

merged 3 commits into from
Oct 6, 2021

Conversation

amanverma21
Copy link
Contributor

Now we can manually select the city of which we want to check the weather.

@netlify
Copy link

netlify bot commented Oct 6, 2021 •
edited

✔️ Deploy Preview for 30daysofjs ready!

🔨 Explore the source changes: dabfcd4

🔍 Inspect the deploy log: https://app.netlify.com/sites/30daysofjs/deploys/615d5b95f7a57d000766d3fe

😎 Browse the preview: https://deploy-preview-64--30daysofjs.netlify.app

@amanverma21
Copy link
Contributor Author

image

swapnilsparsh
swapnilsparsh requested changes Oct 6, 2021
View reviewed changes
Copy link
Owner

@swapnilsparsh swapnilsparsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working great but the background is not changing according to the weather it is the feature that was added in the #59
Please resolve this.

@amanverma21
Copy link
Contributor Author

It's working great but the background is not changing according to the weather it is the feature that was added in the #59 Please resolve this.
It is changing kindly add name of the city which has different weather

@amanverma21
Copy link
Contributor Author

image
image

@swapnilsparsh swapnilsparsh merged commit 8836f92 into swapnilsparsh:master Oct 6, 2021
@swapnilsparsh
Copy link
Owner

@amanverma21 Thank you for your contribution. Looking forward to more such amazing contributions 🥂

@swapnilsparsh swapnilsparsh added hacktoberfest Hacktoberfest hacktoberfest-accepted Hacktoberfest Accepted labels Oct 6, 2021
@amanverma21
Copy link
Contributor Author

Thank you for your contribution. Looking forward to more such amazing contributions 🥂

Thanks a lot!!

@swapnilsparsh swapnilsparsh mentioned this pull request Oct 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swapnilsparsh swapnilsparsh swapnilsparsh requested changes

Assignees
No one assigned
Labels
hacktoberfest Hacktoberfest hacktoberfest-accepted Hacktoberfest Accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amanverma21 @swapnilsparsh