Fixed Preloader #425
Merged
Fixed Preloader #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for devempire ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@swapnilsparsh ,please review and merge my pull request i have fixed preloader |
|
@Nishitbaria As told, add percentage also. |
|
@swapnilsparsh , i have added percentage loader ,please review and merge my pull request |
|
@swapnilsparsh , i have added percentage loader ,please review and merge my pull request |
|
@Nishitbaria Resolve the conflicts. |
|
@swapnilsparsh done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Pull Request
Fixes ISSUE #418
Description:
I have fixed the issue with the preloader in the DevEmpire website by correcting the image path that was causing the preloader to malfunction. The preloader was failing to display due to an incorrect image path reference. This pull request addresses the issue and ensures that the preloader is displayed as expected.
Changes Made:
I updated the image path in the preloader component to point to the correct location of the loading image. The previous path was causing the preloader to not show up, which has now been resolved by providing the accurate image path.
Testing:
I have tested the preloader thoroughly on different devices and browsers to confirm that the fix has successfully resolved the issue. The preloader now displays correctly during page loading.
Impact:
This fix significantly improves the user experience on the DevEmpire website by ensuring that the preloader works as intended. Users will now see the preloader while the content is being loaded, reducing confusion and enhancing the overall perception of the website's performance.
Screenshots:
(Optional: If applicable, you can attach screenshots demonstrating the preloader displaying correctly after the fix.)
I appreciate your review and feedback on this fix. Please let me know if any further adjustments are needed or if there are any concerns related to this pull request.