Add handling of multiple level column names in DataSets #212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @swar ,
Thanks for this amazing repo!
I've figured out a patch for #211 and #98 that is robust to handle
DataSet
objects with an arbitrary number of levels for the column names.For example, the following command should now work:
When running the tests, I got the same number of failures (113, mostly on test_play_by_play_regex_integration) as before starting my work, so I believe my fix doesn't crash any previously-working features.
Hope this helps, and happy to discuss the changes.
Ethan Baron