Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix team_index_championship_year #286

Merged
merged 3 commits into from
Oct 16, 2022

Conversation

llimllib
Copy link
Contributor

@llimllib llimllib commented Oct 16, 2022

  • add championship years to data-updater template
  • re-add team_index_championship_year to static data
  • add Bucks 2021 championship and GSW 2022

Testing:

  • I replaced the broken data.py in my local copy of the library with the one in this PR, and then from nba_api.stats.static import teams worked instead of throwing an exception
  • I added the world's single simplest test, on the theory that any test that imported this file would have thrown an error and so this test would catch it in the future

closes #284

cc @rsforbes

Copy link
Collaborator

@rsforbes rsforbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@llimllib - Many Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: cannot import name 'team_index_championship_year' from 'nba_api.stats.library.data'
2 participants