Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PlayByPlay Regex Updates #59

Merged
merged 11 commits into from
Apr 15, 2019
Merged

PlayByPlay Regex Updates #59

merged 11 commits into from
Apr 15, 2019

Conversation

rsforbes
Copy link
Collaborator

Significantly cleaned up PlayByPlay regex.

  1. All PlayByPlay regex can be used to get items like PlayerName, Offensive Rebounds, Points, Distance of Shot, Assists, Foul Type, Field Goal Type, etc.
  2. Added Tests to validate player data which also demonstrates how to get specific data from the playbyplay field.

@swar swar merged commit 0aa9c51 into swar:master Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rsforbes @swar