Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added active status to static players list #66

Merged
merged 4 commits into from Apr 21, 2019

Conversation

TK05
Copy link
Contributor

@TK05 TK05 commented Apr 21, 2019

Requested by #11

Added a boolean value to the static players list to represent their active status. Added get_active_players() and get_inactive_players() to make use of this new data.

Also updated data.md, examples.md and players.md to reflect these changes.

@TK05
Copy link
Contributor Author

TK05 commented Apr 21, 2019

Also made a tool to update static player data 0251d16

Unfortunately it uses Selenium which isn't so great. I couldn't get the requests_html library to work for whatever reason. If anyone knows if there's an endpoint that could generate this data, feel free to let me know and I'll use that instead.

Basically right now it just scrapes https://stats.nba.com/players/list/.

@swar
Copy link
Owner

swar commented Apr 21, 2019

@swar swar merged commit 18b37e6 into swar:master Apr 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants