Fixed a bug in playbyplay regex #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Second commit is a complete simplification of the playbyplay regex. It solves all issues of player names with the exception of turnover by a player. Still working on that on. |
|
3rd commit for the evening fixes the |
|
4th commit fixes but in older data where referee was not listed. |
|
5th commit fixes bug where referee not included in player violation. |
swar
approved these changes
Oct 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PlayByPlayRegEx was expecting 'Full' but received 'Reg.'
known: TRAIL BLAZERS Timeout: Regular (Full 5 Short 0)
Unknown: Magic Timeout: Regular (Reg.4 Short 0)
Expression updated and test added.