Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all achievements are achievable #1435

Open
1 of 4 tasks
byorgey opened this issue Aug 19, 2023 · 3 comments
Open
1 of 4 tasks

Not all achievements are achievable #1435

byorgey opened this issue Aug 19, 2023 · 3 comments
Labels
Bug The observed behaviour is incorrect or unexpected. C-Low Hanging Fruit Ideal issue for new contributors. G-Achievements Inventing or improving Achievements S-Moderate The fix or feature would substantially improve user experience.

Comments

@byorgey
Copy link
Member

byorgey commented Aug 19, 2023

Unless I am mistaken, I think there are some achievements listed in the Achievements menu which are not actually achievable:

@byorgey byorgey added Bug The observed behaviour is incorrect or unexpected. C-Low Hanging Fruit Ideal issue for new contributors. S-Moderate The fix or feature would substantially improve user experience. G-Achievements Inventing or improving Achievements labels Aug 19, 2023
@xsebek
Copy link
Member

xsebek commented Sep 2, 2023

We could make a integration test checking that given achievement is achievable. 🤔 (Is there a way to depend on other tests so we don’t have to retest all tutorials?)

Imagine if we ended up with achievement descriptions with solution like we have for scenarios. 😄

@byorgey
Copy link
Member Author

byorgey commented Sep 8, 2023

Note, it will not be easy to test all achievements since some may require doing certain things in the menu and so on. But others should certainly be possible to test with a solution.

mergify bot pushed a commit that referenced this issue Sep 11, 2023
Towards #1435.  Some refactoring, + grant `RobotIntoWater` achievement when a robot dies in the water.
@byorgey
Copy link
Member Author

byorgey commented Dec 14, 2023

Does anyone know if there is actually any way to destroy the base? It's actually rather difficult/impossible to do, even in creative mode. We should either (1) get rid of the achievement for destroying the base, or (2) make it possible to do (via some appropriately obscure method). Or perhaps (3) it is already possible and I just haven't figured out how.

Edit: it's hard to do because we have deliberately put in checks to stop the player from doing so accidentally, which is a good thing!

mergify bot pushed a commit that referenced this issue Jan 13, 2024
Grant `CraftedBitcoin` achievement when using the `make` command to craft a `bitcoin`,  not in creative mode, and not a system robot.

Towards #1435 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug The observed behaviour is incorrect or unexpected. C-Low Hanging Fruit Ideal issue for new contributors. G-Achievements Inventing or improving Achievements S-Moderate The fix or feature would substantially improve user experience.
Projects
None yet
Development

No branches or pull requests

2 participants