Allow scrolling the world map unless scrollable: false is set
#1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new boolean key `scrollable` to the world description in scenario files, with a default value of true. Closes #1108.
|
I don't know what happened with the TODO checking. I got an email saying that it didn't run because it was empty, or something like that, and it seems not to be listed among the checks above. |
kostmo
approved these changes
Feb 15, 2023
xsebek
approved these changes
Feb 15, 2023
|
@byorgey could you please paste the message here or forward me the email? I will check why the TODO was not run. 🤨 |
|
@xsebek I can forward you the email, but I don't think I have your email address. You can PM it to me on IRC or something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new boolean key
scrollableto the world description in scenario files, with a default value of true.Closes #1108.