Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better type error messages when there are unification variables involved #1318

Merged
merged 19 commits into from
Jun 11, 2023
Merged

Better type error messages when there are unification variables involved #1318

merged 19 commits into from
Jun 11, 2023

Commits on Jun 5, 2023

  1. WIP: start working on typechecking context stack

    @byorgey
    byorgey committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    ffa4f66 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. refactoring/improvements 

    - Rename `expect` to `unify`
- Add a `Syntax` argument to all `decomposeXXX` functions
- Add `Source` and `Join` machinery to properly keep track of which
  type is "expected" and which is "actual"
    @byorgey
    byorgey committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    833f4a3 View commit details
    Browse the repository at this point in the history

  2. comments

    @byorgey
    byorgey committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    dc3e003 View commit details
    Browse the repository at this point in the history

  3. refactoring: move some code to better locations

    @byorgey
    byorgey committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    73c5e0b View commit details
    Browse the repository at this point in the history

  4. fix test

    @byorgey
    byorgey committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    e5df879 View commit details
    Browse the repository at this point in the history

  5. add some type error message tests

    @byorgey
    byorgey committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    3aaf3de View commit details
    Browse the repository at this point in the history

  6. add explicit applyBindings call when typechecking applications 

    This helps with error messages for multi-argument polymorphic function
application (e.g. `if`).
    @byorgey
    byorgey committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    d47ac2f View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. WIP: typechecking stack, a few basic frames, and very basic pretty-pr… 

    …inting
    @byorgey
    byorgey committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    4dd25a7 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. Restyled by fourmolu (#1309) 

    Co-authored-by: Restyled.io <commits@restyled.io>
    @restyled-io @restyled-commits
    restyled-io[bot] and restyled-commits committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    2a0cdfd View commit details
    Browse the repository at this point in the history

  2. update some comments

    @byorgey
    byorgey committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    f5a9944 View commit details
    Browse the repository at this point in the history

  3. implement hlint suggestion

    @byorgey
    byorgey committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    3fca294 View commit details
    Browse the repository at this point in the history

  4. fix Haddock syntax

    @byorgey
    byorgey committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    9675354 View commit details
    Browse the repository at this point in the history

  5. formatting

    @byorgey
    byorgey committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    46319fd View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. Merge branch 'main' into feature/typechecking-stack

    @byorgey
    byorgey committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    c76bdb9 View commit details
    Browse the repository at this point in the history

  2. better type error messages when there are unification variables 

    Closes #1313.
    @byorgey
    byorgey committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    897d88e View commit details
    Browse the repository at this point in the history

  3. Restyled by fourmolu (#1319) 

    Co-authored-by: Restyled.io <commits@restyled.io>
    @restyled-io @restyled-commits
    restyled-io[bot] and restyled-commits committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    6a90a01 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2023

  1. Merge branch 'main' into feature/english-type-errors

    @byorgey
    byorgey committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    9cff526 View commit details
    Browse the repository at this point in the history

  2. add some tests illustrating equating incompatible functions

    @byorgey
    byorgey committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    e233b4f View commit details
    Browse the repository at this point in the history

  3. one more test case

    @byorgey
    byorgey committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    eca9a68 View commit details
    Browse the repository at this point in the history