Robot activity counts in F2 menu #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostmo
force-pushed
the
feature/command-count
branch
from
d46c986
to
7513c62
Compare
kostmo
force-pushed
the
feature/command-count
branch
4 times, most recently
from
77783eb
to
7d246ec
Compare
kostmo
added
the
CHANGELOG
kostmo
commented
Sep 4, 2023
xsebek
reviewed
Sep 4, 2023
byorgey
reviewed
Sep 4, 2023
kostmo
commented
Sep 4, 2023
kostmo
commented
Sep 4, 2023
Co-authored-by: Brent Yorgey <byorgey@gmail.com>
kostmo
force-pushed
the
feature/command-count
branch
from
9b69d2c
to
e3893bb
Compare
kostmo
force-pushed
the
feature/command-count
branch
from
967bbfd
to
099f773
Compare
kostmo
force-pushed
the
feature/command-count
branch
from
099f773
to
c1d8ef0
Compare
byorgey
reviewed
Sep 6, 2023
There was a problem hiding this comment.
This is looking good! I think this will give a lot of useful information when debugging robot programs. I think there are just a few more things to clean up / resolve before merging.
- Do you have any idea why
idler1only ever gets to 98.4% Activity? Seems to me like it ought to be 100%.- Edited to add: I think it's because the
gameTickfunction runs all robots, then increments the current tick. So at the time we are rendering a frame, the current tick will always be strictly greater than any ticks stored in theWindowedCounterfor any robot; hencegetOccupancywill never be 1.
- Edited to add: I think it's because the
- We should probably add a wiki page somewhere that explains in detail what each of the columns means, and link to it from somewhere (e.g. the bottom of the Robots panel). In particular I imagine many players will be confused about the difference between actions, commands, and cycles. I don't care whether we do that in this PR or split it out into another issue and do it later.
kostmo
force-pushed
the
feature/command-count
branch
from
05cb68e
to
2e6fbcb
Compare
byorgey
reviewed
Sep 6, 2023
8 tasks
mergify bot
pushed a commit
that referenced
this pull request
Oct 1, 2023
Extension of #1484 that partially mitigates #1558. Let's not bother to track the activity levels of system robots when we're not in creative mode, because they won't even show up in the `F2` dialog. This mitigation can be substantial, as we generally expect there to be many more system robots than player robots. It doesn't have quite the same "warm up" drawback as the potential mitigation described in #1558 (comment), because player robots will always be warmed up, and system robots will have been warmed up if we've been playing in creative mode. We wouldn't necessarily expect frequent toggling in-and-out of creative mode while trying to observe performance in the `F2` dialog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #1341.