fix 500 for GET requests to kongregate auth. swarmsim/swarm#630

lib/passport-kongregate/strategy.coffee

@@ -28,11 +28,13 @@ module.exports = class Strategy extends passport.Strategy
     super()
 
   authenticate: (req, options={}) ->
+    params = req.body
+    if !params?
+      return @fail {}, 404
     req.checkBody('user_id').notEmpty().isInt()
     req.checkBody('game_auth_token').notEmpty()
-    params = req.body
     if (errors=req.validationErrors())
-      @fail {errors:errors}, 400
+      return @fail {errors:errors}, 400
     creds = {user_id:params.user_id, game_auth_token:params.game_auth_token}
     kong_args = _.extend {api_key:@options.apiKey}, creds
     sails.log.debug 'kongregate auth', kong_args

test/lib/passport-kongregate/strategy.test.coffee

@@ -51,3 +51,18 @@ describe 'kongregate passport', ->
         user_id: 111
         game_auth_token: 'token'
       @strategy.authenticate req
+
+  it 'fails for GET requests', (done) =>
+    @user = {}
+    @https =
+      get: sinon.spy (url, cb) =>
+        assert false
+    @protocol = sinon.spy (req, creds, profile, cb) =>
+      assert false
+    @strategy = new Strategy {apiKey: 'thekey', https: @https}, @protocol
+    @strategy.success = @strategy.error = sinon.stub().throws()
+    @strategy.fail = =>
+      done()
+    stubreq (req) =>
+      delete req.body
+      @strategy.authenticate req