Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify acquire method's signature changed in CHANGELOG.md #136

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

luislobo
Copy link
Contributor

@luislobo luislobo commented Nov 16, 2022

Hi,

Our team detected that there are breaking changes coming from an old version (1.x) to 3.1.0+

The CHANGELOG.md mentions about a breaking change, but it says to replace from FairSemaphore to Semaphore but it doesn't warn that the acquire method no longer returns a boolean, and rather, throws when it cannot acquire, and returns nothing.

I think it would be good to add this into the CHANGELOG.md entry, in case other are coming from an old version (like us).

Thank you!

Luis

@luislobo luislobo mentioned this pull request Nov 16, 2022
@swarthy swarthy merged commit dbd4f71 into swarthy:master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants