Clarify acquire
method's signature changed in CHANGELOG.md
#136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Our team detected that there are breaking changes coming from an old version (1.x) to 3.1.0+
The CHANGELOG.md mentions about a breaking change, but it says to replace from
FairSemaphore
toSemaphore
but it doesn't warn that theacquire
method no longer returns a boolean, and rather, throws when it cannot acquire, and returns nothing.I think it would be good to add this into the CHANGELOG.md entry, in case other are coming from an old version (like us).
Thank you!
Luis