Use wp_add_inline_script for publicPath
#18
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows one to take advantage of filtering via `wp_inline_script_attributes`, which is particularly important for implementing CSP.
joshuafredrickson
added a commit
to joshuafredrickson/responsive-pics
that referenced
this pull request
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows one the ability to filter script attributes via
wp_inline_script_attributes, which is particularly important for implementing Content-Security-Policy.Without the ability to filter scripts attributes, there is no way to allow this script to safely run when the CSP requires disabling
unsafe-inline.Reference: https://core.trac.wordpress.org/ticket/39941