Unsupported window_type criteria

[makepanic]

Hi,
thanks for the great work on sway.
With beta.1 i tried to checkout sway again and ported various things from my i3 config to sway.

I noticed that some of the criteria aren't supported, e.g. for_window [window_type="menu"] floating enable won't compile.

Looking at the source, it looks like there's a hardcoded list of supported types

https://github.com/swaywm/sway/blob/master/sway/criteria.c#L278-L290

There are some i3 configs that user additional window_type filters.

If https://metacpan.org/pod/X11::Protocol::WM#_NET_WM_WINDOW_TYPE is correct, then this is the list of possible types:

sway	metacpan
NORMAL	NORMAL
DIALOG	DIALOG
not implemented	DESKTOP
not implemented	DOCK
TOOLBAR	TOOLBAR
not implemented	MENU
UTILITY	UTILITY
SPLASH	SPLASH

Then there's also the freedesktop spec https://standards.freedesktop.org/wm-spec/wm-spec-latest.html#idm140200472629520

sway	freedesktop
NORMAL	NORMAL
DIALOG	DIALOG
not implemented	DESKTOP
not implemented	DOCK
TOOLBAR	TOOLBAR
not implemented	MENU
UTILITY	UTILITY
SPLASH	SPLASH
not implemented	DROPDOWN_MENU
not implemented	POPUP_MENU
not implemented	TOOLTIP
not implemented	NOTIFICATION
not implemented	COMBO
not implemented	DND

If this is something sway should support, I could try to open a PR and extend the if/else condition block.
I'm not fluent enough with c so it'll also be fine if someone else does it properly :)

[ascent12]

A few of these are very X11 specific and wouldn't work in Wayland at all (e.g. DESKTOP, DOCK), but I suppose it's not particularly hard to just add more stuff to that if-else chain.

[RyanDwyer]

Fixed by the above PR.