Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase the cursor when re-ordering layer surfaces #3080

Open
Limero opened this issue Nov 5, 2018 · 3 comments
Open

Rebase the cursor when re-ordering layer surfaces #3080

Limero opened this issue Nov 5, 2018 · 3 comments
Labels
bug Not working as intended

Comments

@Limero
Copy link

Limero commented Nov 5, 2018

I first reported this to slurp, but this is apparently a sway bug according to @emersion, so the steps below will be from that issue.

When you run slurp, the cursor will remain regular until you move it, and then, it will turn into the crosshair.

This causes a problem when running slurp and directly doing a selection, the selection will not be highlighted and the resulting selection will have an empty x and y value, like this: 0,0 1144x753

Steps to replicate:

  1. Open a terminal and run slurp
  2. Don't move the cursor
  3. Notice the cursor still being regular, not a crosshair
  4. Press the primary mouse button and drag a selection
  5. Notice the selection not being highlighted and the result having x/y values set to 0

Sway version: sway version 1.0-beta.1-151-ge9c77970 (Nov 5 2018, branch 'master')

@emersion emersion added the bug Not working as intended label Nov 17, 2018
emersion added a commit to emersion/sway that referenced this issue Feb 12, 2019
Also removes an extraneous arrange_outputs call, it's already called if
necessary in arrange_layers.

Updates swaywm#3080
@emersion
Copy link
Member

We now correctly rebase on map.

We should also rebase on commit if it re-arranges layer surfaces. This requires detecting when layer surfaces need to be moved or resized.

ddevault pushed a commit that referenced this issue Feb 18, 2019
Also removes an extraneous arrange_outputs call, it's already called if
necessary in arrange_layers.

Updates #3080
@Limero
Copy link
Author

Limero commented Feb 20, 2019

Is there more to be done or can this be closed? Cursor updates correctly in slurp after recent changes, so I'm happy 😄

@emersion
Copy link
Member

Yes, we should rebase the cursor when a layer surface changes its size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Not working as intended
Development

No branches or pull requests

2 participants