Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version number is unreliable #4631

Closed
emersion opened this issue Oct 12, 2019 · 1 comment · Fixed by #4634
Closed

Version number is unreliable #4631

emersion opened this issue Oct 12, 2019 · 1 comment · Fixed by #4634

Comments

@emersion
Copy link
Member

The version we get from Git is unreliable. At the time of writing it says 1.2-rc1 although the latest release is 1.2. This happens because 1.2 has been tagged on the v1.2 branch, not on master. When building from master the latest tag is 1.2-rc1.

Not sure how to fix this.
@dnkl
Copy link
Contributor

dnkl commented Oct 13, 2019

Merging the 1.2-branch into master will make the 1.2 tag "visible" in master too.

emersion added a commit to emersion/sway that referenced this issue Oct 14, 2019
@emersion
build: always use the project version
8564e32 
Don't use the latest tag, always use the project version for the version
string. Because of version branches, getting the version from Git can be
unreliable.

Closes: swaywm#4631
@emersion emersion mentioned this issue Oct 14, 2019
Merged
ddevault pushed a commit that referenced this issue Oct 16, 2019
@emersion @ddevault
build: always use the project version
72ba9be 
Don't use the latest tag, always use the project version for the version
string. Because of version branches, getting the version from Git can be
unreliable.

Closes: #4631
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: always use the project version emersion/sway
2 participants
@emersion @dnkl