Repaint scheduling ("max_render_time") broken #4768
Labels
bug
Not working as intended
Comments
kennylevinsen
added a commit
to kennylevinsen/sway
that referenced
this issue
Nov 30, 2019
Repaint scheduling delays output render and frame done events from output frame events, and block idle frame events from being scheduled in between output frame done and output render in this period of time. If a surface is committed after its frame done event, but before output render, idle frame requests will be blocked, and the surface relies on the upcoming render to schedule a frame. If when the repaint timer expires, output render is deemed unnecessary, no frame will be scheduled. This can lead to surfaces never having their frame callbacks fire. To fix this, we store that a surface has requested a frame in surface_needs_frame. When the repaint expires, if no render is deemed necessary, we check this flag and schedule an idle frame. Fixes swaywm#4768
kennylevinsen
added a commit
to kennylevinsen/sway
that referenced
this issue
Nov 30, 2019
Repaint scheduling delays output render and frame done events from output frame events, and block idle frame events from being scheduled in between output frame done and output render in this period of time. If a surface is committed after its frame done event, but before output render, idle frame requests will be blocked, and the surface relies on the upcoming render to schedule a frame. If when the repaint timer expires, output render is deemed unnecessary, no frame will be scheduled. This can lead to surfaces never having their frame callbacks fire. To fix this, we store that a surface has requested a frame in surface_needs_frame. When the repaint expires, if no render is deemed necessary, we check this flag and schedule an idle frame. Fixes swaywm#4768
kennylevinsen
added a commit
to kennylevinsen/sway
that referenced
this issue
Nov 30, 2019
Repaint scheduling delays output render and frame done events from output frame events, and block idle frame events from being scheduled in between output frame done and output render in this period of time. If a surface is committed after its frame done event, but before output render, idle frame requests will be blocked, and the surface relies on the upcoming render to schedule a frame. If when the repaint timer expires, output render is deemed unnecessary, no frame will be scheduled. This can lead to surfaces never having their frame callbacks fire. To fix this, we store that a surface has requested a frame in surface_needs_frame. When the repaint expires, if no render is deemed necessary, we check this flag and schedule an idle frame. Fixes swaywm#4768
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are known issues with repaint scheduling. Offsetting frame_done to occur before output_render is not currently possible without causing issues.
This issue stem from interactions with the block_idle_frame. A fix was made in master that makes an output max_render_time work, but it does not improve the situation where a view max_render_time is also in effect.
The text was updated successfully, but these errors were encountered: