Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only titlebar of window is shown on monitor with negative offset #4908

Closed
adee opened this issue Jan 14, 2020 · 6 comments · Fixed by #4911
Closed

Only titlebar of window is shown on monitor with negative offset #4908

adee opened this issue Jan 14, 2020 · 6 comments · Fixed by #4911

Comments

@adee
Copy link
Contributor

adee commented Jan 14, 2020

Sway Version: sway version 1.2-c3353bb2 (Jan 14 2020, branch 'master')
swaymsg -t get_outputs:
Output eDP-1 'Chimei Innolux Corporation 0x15E8 0x00000000' (focused)
Current mode: 1920x1080 @ 60.007999 Hz
Position: 0,0
Output DP-1 'Dell Inc. DELL U2414H 292K47580FWL'
Current mode: 1920x1080 @ 60.000000 Hz
Position: 0,-1080

If a window is positioned to a monitor with negative offset, windows with titlebar only show the title part. If I reconfigure the layout to use positive offsets/open on the primary everything is ok.
Please witness the attached screenshot.

To reproduce:

  • Open any window with a config that shows titlebars on the monitor with negative offset. I tried virt-manager.
    or:
  • drag a floating window to the secondary. The window part disappears when it reaches the secondary.

With default configuration the entire virt-manager main window is invisible (except the titlebar). My config omits titlebars for tiled windows.

Screenshot: https://imgur.com/li52zF2

@vijfhoek
Copy link

I don't have this problem on sway version 1.2 (from the Arch Linux repos, package version 1:1.2-5).

My outputs:

Output eDP-1 'Unknown 0x06D7 0x00000000' (focused)
  Current mode: 3840x2160 @ 59.997002 Hz
  Position: 0,0
  Scale factor: 2.000000

Output HDMI-A-2 'Philips Consumer Electronics Company PHL 243V7 0x000034F5'
  Current mode: 1920x1080 @ 74.973000 Hz
  Position: 960,-1080
  Scale factor: 1.000000

Output DP-1 'Philips Consumer Electronics Company PHL 243V7 0x000034F4'
  Current mode: 1920x1080 @ 74.973000 Hz
  Position: -960,-1080
  Scale factor: 1.000000

@adee
Copy link
Contributor Author

adee commented Jan 14, 2020

I don't have this problem on sway version 1.2 (from the Arch Linux repos, package version 1:1.2-5).

My outputs:

Output eDP-1 'Unknown 0x06D7 0x00000000' (focused)
  Current mode: 3840x2160 @ 59.997002 Hz
  Position: 0,0
  Scale factor: 2.000000

Output HDMI-A-2 'Philips Consumer Electronics Company PHL 243V7 0x000034F5'
  Current mode: 1920x1080 @ 74.973000 Hz
  Position: 960,-1080
  Scale factor: 1.000000

Output DP-1 'Philips Consumer Electronics Company PHL 243V7 0x000034F4'
  Current mode: 1920x1080 @ 74.973000 Hz
  Position: -960,-1080
  Scale factor: 1.000000

Please note the fact that you're using the last stable release while I use the git master. This problem is relatively recent even in that (1-2 months old maybe?). I just noticed it now.

@purew
Copy link

purew commented Jan 14, 2020

Can confirm this bug.

output "DP-1" {
    pos 1920 0
    background $background2 fill
}

works fine.

output "DP-1" {
    pos 1920 -400
    background $background2 fill
}

shows only titlebar on that second monitor.

On wlroot:062583ed and sway:c3353bb2 and this is a regression. The packaged 1.2 version in arch does not have this problem.

@adee
Copy link
Contributor Author

adee commented Jan 14, 2020

The culprit is 79c5f5b. Reverting that makes this go away.

@emersion
Copy link
Member

cc @pedrocr

@pedrocr
Copy link
Contributor

pedrocr commented Jan 14, 2020

That commit can be reverted without affecting anything else. Nothing depended on that and no behavior was supposed to change. It was a change towards correctness that as far as I could tell didn't exhibit bad behaviors. Since there is at least this bug I'd say reverting is the prudent choice given the release cycle.

After 1.3 is released a more thorough patch that fixes all situations of implicit casts may be the only way to be sure there are no other bugs.

emersion added a commit to emersion/sway that referenced this issue Jan 15, 2020
emersion added a commit that referenced this issue Jan 15, 2020
emersion added a commit that referenced this issue Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

5 participants