Input are not correctly forwarded to XWayland windows #4926

ghost · 2020-01-18T12:33:42Z

Hello,

I'm currently testing the 1.3 version, and I have found a what I think could be a bug : When a popup is spawned by a XWayland window and I close it, Sway refocus the window that spawned the popup. Unfortunately, the keyboard is not sending any input to the window even if sway is marking this window as being currently focused.
I can reproduce this issue with several application on current release-candidate like vscode for instance.

Let me know if I can provide some details about this issue !

> swaymsg -t get_version
sway version 1.3-rc3

The text was updated successfully, but these errors were encountered:

emersion · 2020-01-18T12:37:33Z

Your bug report is missing debug logs. Please add a link to the full debug log file.
Your bug report is missing your config file. Please add a link to it.

emberfade · 2020-01-30T10:19:03Z

I think I have the same issue.

Sway Version:

sway version 1.4

Debug Log:

sway.log

Configuration File:

Default

Reproduction:

What I did in the debug log:

Open terminal (Super+Enter)
$ firefox
Open Bookmark Overview (Ctrl+Shift+O)
Make sure mouse cursor is above the newly spawned window
Close Bookmark Overview (Ctrl+W).
No keyboard input is possible on Firefox until focus has been switched to another window.

Additional Information:

This happened with other XWayland windows as well.

It is neccessary to move the mouse onto the new window. Otherwise the main window will take input from the keyboard as usual when the second window is closed.

Edit: Be more specific that it is about the input from the keyboard.

ghost · 2020-01-30T21:48:25Z

Hello, sorry for the late answer I was a bit short at the moment. I can confirm that what @emberfade is reporting is exactly the behavior I was first reporting.

josefbachmann · 2020-02-01T21:30:01Z

I think I have the same issue.
* Sway Version:
sway version 1.4

Same sway version, same problem. I can reproduce this as well and came here for this.

Firefox: Mozilla Firefox 72.0.2
Linux: 5.4.15-arch1-1

emberfade · 2020-02-02T00:27:07Z

I've tried using git bisect for the first time. So my result may not be accurate.

I believe that the commit introducing the bug is not within sway but wlroots swaywm/wlroots@c067fbc

kdryja · 2020-02-02T22:12:38Z

Same issue here.

Config and Debug

debug.log
Reproducible with default config

Repro

Start Sway
Open any XWayland app (tested on Google Chrome Version 80.0.3987.78 (Official Build) beta (64-bit) and IntelliJ)
(For Google Chrome) Open any contextual window, e.g. Ctrl+O
Close the contextual window by hitting ESC
Focus on main Chrome window is now lost and can only be reclaimed by switching to different workspace and then back (e.g. if chrome is on workspace 1, I have to run $mod+2 then $mod+1 to regain focus)

Sway Version

sway version 1.4
xorg-server-xwayland 1.20.7
wlroots-0.10.0

stlaz · 2020-02-03T07:48:27Z

Seeing the same problem. I tried to tail -f on the debug log, but nothing seems to be logged (although eventually you get
2020-02-02 22:02:29 - [sway/input/cursor.c:730] denying request to set cursor from unfocused client, not sure if it's related to it)

Even if we allow the focus change to the new window, we have to send the focus explicitly. Otherwise the focus may get lost when we close a window belonging to the same process, but do not send focus to the remaining window. Fixes swaywm/sway#4926

Emantor · 2020-02-03T08:10:12Z

Please test swaywm/wlroots#2017, at least in my testing the chrome issue did not appear. I am currently on a train, so I can't realy test steam and other apps.

m0ppers · 2020-02-04T18:01:30Z

same here. sway 1.2, wlroots 0.8.1 working. sway 1.4/wlroots 0.10 is not. My steps to reproduce:

open hexchat, dismiss the "shall I join a channel" popup after connecting. Input focus goes away and need to switch back and forth between workspaces to make input work again.

The first problem I ever had with sway :D keep up the good work :)

jbiel · 2020-02-17T18:22:04Z

I'm on Arch with wlroots 0.10.0-2 and sway 1.4-7 and this happens to me maybe 1 out of 20 times when opening a new tab in Firefox (using X11Wayland for it because native Wayland support was terrible last time I tried it.) The Firefox window is focused (blue title bar) with the cursor flashing in the address bar, but won't accept input until I focus another window and switch back.

jfchevrette · 2020-02-17T18:36:01Z

Arch with sway 1.4 with wlroots 0.10.0-2, this happens to me a lot when using Visual Studio code as well as Firefox

norpol · 2020-02-18T12:58:14Z

Similar issue with Signal Desktop and attaching files, clicking onto my wallpaper and back into the main window of the application restores keyboard input focus for me.

@jbiel:

Firefox (using X11Wayland for it because native Wayland support was terrible last time I tried it

Maybe give it a try again, works quite well for me on arch.

jubalh · 2020-02-18T13:05:19Z

@norpol ??

Ogromny · 2020-02-19T00:19:38Z

Same issue with JetBrains >=2019.2.X IDE

This reflects what i3 does [1]. [1]: https://github.com/i3/i3/blob/b3faf9fca9254679a4715486a4de80ebaee70410/src/handlers.c#L1076 Fixes: c067fbc ("xwm: allow applications to change focus between their own surfaces") Closes: swaywm/sway#4926

emersion · 2020-02-19T10:00:36Z

Can you try swaywm/wlroots#2035?

This reflects what i3 does [1]. [1]: https://github.com/i3/i3/blob/b3faf9fca9254679a4715486a4de80ebaee70410/src/handlers.c#L1076 Fixes: c067fbc ("xwm: allow applications to change focus between their own surfaces") Closes: swaywm/sway#4926

p-e-w · 2020-02-26T05:01:27Z

Is there going to be a patch release with this fix? This is a major regression from Sway 1.2, and makes many applications practically unusable, with no apparent workaround (other than downgrading Sway).

emersion · 2020-02-26T07:54:14Z

I'm thinking about it. We'll discuss with the other core contributors.

abmantis · 2020-02-28T19:17:20Z

Also, considering that wlroots requires Wayland 1.18, it is impossible to easily update on Ubuntu 19.04 (the latest), in order to get this fix.

This reflects what i3 does [1]. [1]: https://github.com/i3/i3/blob/b3faf9fca9254679a4715486a4de80ebaee70410/src/handlers.c#L1076 Fixes: c067fbc ("xwm: allow applications to change focus between their own surfaces") Closes: swaywm/sway#4926 (cherry picked from commit 68820d6)

This reflects what i3 does [1]. [1]: https://github.com/i3/i3/blob/b3faf9fca9254679a4715486a4de80ebaee70410/src/handlers.c#L1076 Fixes: c067fbc ("xwm: allow applications to change focus between their own surfaces") Closes: swaywm/sway#4926

glyh · 2022-07-21T11:36:15Z

I've encounter this in some DirectX games, is there some workaround or should it just work?

ammgws · 2022-07-21T12:09:15Z

Have you tried running the game via gamescope?

glyh · 2022-07-21T12:41:06Z

@ammgws I just tried it, it's working now. Thank you :)

ghost changed the title ~~[Bug] Input are not correctly forwarded to XWayland windows~~ Input are not correctly forwarded to XWayland windows Jan 18, 2020

Emantor mentioned this issue Feb 3, 2020

xwm: correctly send focus event to new window swaywm/wlroots#2017

Closed

emersion mentioned this issue Feb 19, 2020

xwayland: ignore pointer focus changes swaywm/wlroots#2035

Merged

RedSoxFan closed this as completed in swaywm/wlroots#2035 Feb 19, 2020

emersion mentioned this issue Mar 15, 2020

Firefox (xwayland) occasionally stops receiving keyboard events #5114

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Input are not correctly forwarded to XWayland windows #4926

Input are not correctly forwarded to XWayland windows #4926

ghost commented Jan 18, 2020

emersion commented Jan 18, 2020

emberfade commented Jan 30, 2020 •

edited

Loading

ghost commented Jan 30, 2020

josefbachmann commented Feb 1, 2020 •

edited

Loading

emberfade commented Feb 2, 2020

kdryja commented Feb 2, 2020

stlaz commented Feb 3, 2020

Emantor commented Feb 3, 2020

m0ppers commented Feb 4, 2020

jbiel commented Feb 17, 2020

jfchevrette commented Feb 17, 2020

norpol commented Feb 18, 2020 •

edited

Loading

jubalh commented Feb 18, 2020

Ogromny commented Feb 19, 2020

emersion commented Feb 19, 2020

p-e-w commented Feb 26, 2020

emersion commented Feb 26, 2020

abmantis commented Feb 28, 2020

glyh commented Jul 21, 2022

ammgws commented Jul 21, 2022

glyh commented Jul 21, 2022

Input are not correctly forwarded to XWayland windows #4926

Input are not correctly forwarded to XWayland windows #4926

Comments

ghost commented Jan 18, 2020

emersion commented Jan 18, 2020

emberfade commented Jan 30, 2020 • edited Loading

Debug Log:

Configuration File:

Reproduction:

Additional Information:

ghost commented Jan 30, 2020

josefbachmann commented Feb 1, 2020 • edited Loading

emberfade commented Feb 2, 2020

kdryja commented Feb 2, 2020

Config and Debug

Repro

Sway Version

stlaz commented Feb 3, 2020

Emantor commented Feb 3, 2020

m0ppers commented Feb 4, 2020

jbiel commented Feb 17, 2020

jfchevrette commented Feb 17, 2020

norpol commented Feb 18, 2020 • edited Loading

jubalh commented Feb 18, 2020

Ogromny commented Feb 19, 2020

emersion commented Feb 19, 2020

p-e-w commented Feb 26, 2020

emersion commented Feb 26, 2020

abmantis commented Feb 28, 2020

glyh commented Jul 21, 2022

ammgws commented Jul 21, 2022

glyh commented Jul 21, 2022

emberfade commented Jan 30, 2020 •

edited

Loading

josefbachmann commented Feb 1, 2020 •

edited

Loading

norpol commented Feb 18, 2020 •

edited

Loading