Command criteria only match views

[anrdnet]

Some criteria match container attributes (e.g. con_mark, con_id, floating) and many commands operate on containers, but there's no way to apply commands to non-leaf containers using criteria.

$ swaymsg 'splitv'
$ xterm &
$ swaymsg 'focus parent; mark test; focus child'
$ swaymsg '[con_mark="test"] focus'
Error: No matching node.

In i3 this will correctly focus the parent container.

From what I understand criteria are expanded using criteria_get_views which, as the name suggests, only returns views. handler_context.container is then set to view->container. I believe this can be solved by matching on containers instead of views. I can try to make a patch if that is of interest.

• Sway Version:

$ swaymsg -t get_version
sway version 1.2

but doesn't appear to have changed on current master.

• Debug Log:
  I don't believe the relevant code paths do much logging. Please let me know otherwise.

• Configuration File:
  Reproducible with empty/default configuration.

[emersion]

Patches are definitely welcome to fix this.