Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output flashes after tty switch #5086

Closed
kchibisov opened this issue Mar 9, 2020 · 2 comments · Fixed by swaywm/wlroots#2065
Closed

Output flashes after tty switch #5086

kchibisov opened this issue Mar 9, 2020 · 2 comments · Fixed by swaywm/wlroots#2065
Labels
bug Not working as intended

Comments

@kchibisov
Copy link
Contributor

After doing TTY switch back to sway the entire screen flashes until I open something/change currently focused window(moving cursor doesn't fix it). As you can see on a gif it seems like the issue is related to damage tracking, since everything is black, except for updated cpu meter and time on a status bar at the bottom (they are rendered correctly).

IMG-0275

sway version:
sway version 1.4-fafc0609

Bug doesn't happen with sway-1.4 stable release

sway-damage.log

@kchibisov
Copy link
Contributor Author

It seems like it was introduced by swaywm/wlroots@a4c7c6d or swaywm/wlroots@7bce056 (The first commit crashes for me right away, so can't say precisely)

@emersion
Copy link
Member

Fix is available here: swaywm/wlroots#2059

@emersion emersion added the bug Not working as intended label Mar 10, 2020
emersion added a commit to emersion/wlroots that referenced this issue Mar 12, 2020
This patch disambiguates the needs_frame event by uncoupling it from
damage. A new separate damage event is emitted when the backend damages
the output (this happens e.g. VT is changed or software cursors are
used). The event specifies the damaged region.

The wlr_output.damage field is removed. wlr_output is no longer
responsible for tracking its own damage, this is wlr_output_damage's
job.

This is a breaking change, but wlr_output_damage users shouldn't need an
update.

Bugs fixed:

- Screen flashes on VT switch
- Cursor damage issues on the X11 and headless backends

Closes: swaywm/sway#5086
ddevault pushed a commit to swaywm/wlroots that referenced this issue Mar 12, 2020
This patch disambiguates the needs_frame event by uncoupling it from
damage. A new separate damage event is emitted when the backend damages
the output (this happens e.g. VT is changed or software cursors are
used). The event specifies the damaged region.

The wlr_output.damage field is removed. wlr_output is no longer
responsible for tracking its own damage, this is wlr_output_damage's
job.

This is a breaking change, but wlr_output_damage users shouldn't need an
update.

Bugs fixed:

- Screen flashes on VT switch
- Cursor damage issues on the X11 and headless backends

Closes: swaywm/sway#5086
filips pushed a commit to filips/wlroots that referenced this issue Mar 15, 2020
This patch disambiguates the needs_frame event by uncoupling it from
damage. A new separate damage event is emitted when the backend damages
the output (this happens e.g. VT is changed or software cursors are
used). The event specifies the damaged region.

The wlr_output.damage field is removed. wlr_output is no longer
responsible for tracking its own damage, this is wlr_output_damage's
job.

This is a breaking change, but wlr_output_damage users shouldn't need an
update.

Bugs fixed:

- Screen flashes on VT switch
- Cursor damage issues on the X11 and headless backends

Closes: swaywm/sway#5086
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Not working as intended
2 participants