Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eclipse windows flicker #5087

Closed
J0nnyMak0 opened this issue Mar 9, 2020 · 5 comments · Fixed by swaywm/wlroots#2061
Closed

Eclipse windows flicker #5087

J0nnyMak0 opened this issue Mar 9, 2020 · 5 comments · Fixed by swaywm/wlroots#2061
Labels
bug Not working as intended

Comments

@J0nnyMak0
Copy link
Contributor

I'm seeing bad window flicker in Eclipse. Started happening in the last couple of days. I see this in the log. This is for the initial splash screen, but the same thing is happening with the regular window/tabs in Eclipse.

(Eclipse:3358): Gtk-WARNING **: 11:41:10.120: Negative content height -1 (allocation 1, extents 1x1) while allocating gadget (node scrolledwindow, owner GtkScrolledWindow)
00:01:52.472 [types/wlr_surface.c:615] New wlr_surface 0x5610fba4da80 (res 0x5610fba316a0)
00:01:52.472 [types/xdg_shell/wlr_xdg_surface.c:458] new xdg_surface 0x5610fba31b50 (res 0x5610fba38fe0)
00:01:52.472 [sway/desktop/xdg_shell.c:493] New xdg_shell popup

sway version 1.4-fafc0609 (Mar  9 2020, branch 'master')

Is this Eclipse or Sway?
@emersion
Copy link
Member

emersion commented Mar 9, 2020

Can you try xwayland master? xwayland recently had some issues with its buffers.

@J0nnyMak0
Copy link
Contributor Author

J0nnyMak0 commented Mar 9, 2020 •
edited
Loading

I think Eclipse is running natively in Wayland with GTK3. If I run with GDK_BACKEND=x11 there is no flicker.

Edit: upgraded to xwayland master anyway and that didn't make a difference.

@J0nnyMak0
Copy link
Contributor Author

Here are the offending commits:
Sway: 9d0aa0c
Wlroots: swaywm/wlroots@8afc1ed

@emersion emersion added the bug Not working as intended label Mar 9, 2020
emersion added a commit to emersion/wlroots that referenced this issue Mar 9, 2020
@emersion
buffer: remove unused wlr_client_buffer fields
e182198 
Forgot to remove these, they are superseded by fields in wlr_buffer. Some
functions were still using them.

Fixes: 8afc1ed ("Introduce wlr_client_buffer")
Closes: swaywm/sway#5087
@emersion emersion mentioned this issue Mar 9, 2020
Merged
@emersion
Copy link
Member

emersion commented Mar 9, 2020

Can you try swaywm/wlroots#2061?

ddevault pushed a commit to swaywm/wlroots that referenced this issue Mar 9, 2020
@emersion @ddevault
buffer: remove unused wlr_client_buffer fields
41f9916 
Forgot to remove these, they are superseded by fields in wlr_buffer. Some
functions were still using them.

Fixes: 8afc1ed ("Introduce wlr_client_buffer")
Closes: swaywm/sway#5087
@J0nnyMak0
Copy link
Contributor Author

Yes, that fixed it. Thanks!

filips pushed a commit to filips/wlroots that referenced this issue Mar 15, 2020
@emersion @filips
buffer: remove unused wlr_client_buffer fields
12fe8c0 
Forgot to remove these, they are superseded by fields in wlr_buffer. Some
functions were still using them.

Fixes: 8afc1ed ("Introduce wlr_client_buffer")
Closes: swaywm/sway#5087
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Not working as intended
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

buffer: remove unused wlr_client_buffer fields emersion/wlroots
2 participants
@emersion @J0nnyMak0