-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tablet pen proximity_out event not delivered if tablet has left surface #5230
Labels
Comments
Xyene
added a commit
to Xyene/sway
that referenced
this issue
Apr 19, 2020
If we started holding the tool tip down on a surface that accepts tablet v2, we should notify that surface if it gets released over a surface that doesn't support v2. Since GTK supports tablet v2, this fixes the common case of starting a drag over a GTK surface (e.g. scrollbar) and releasing it outside (e.g. over the gaps between sway containers, or in a terminal). Refs swaywm#5230.
Xyene
added a commit
to Xyene/sway
that referenced
this issue
Apr 19, 2020
If we started holding the tool tip down on a surface that accepts tablet v2, we should notify that surface if it gets released over a surface that doesn't support v2. Since GTK supports tablet v2, this fixes the common case of starting a drag over a GTK surface (e.g. scrollbar) and releasing it outside (e.g. over the gaps between sway containers, or in a terminal). Refs swaywm#5230.
Xyene
added a commit
to Xyene/sway
that referenced
this issue
Apr 19, 2020
If we started holding the tool tip down on a surface that accepts tablet v2, we should notify that surface if it gets released over a surface that doesn't support v2. Since GTK supports tablet v2, this fixes the common case of starting a drag over a GTK surface (e.g. scrollbar) and releasing it outside (e.g. over the gaps between sway containers, or in a terminal). Refs swaywm#5230.
emersion
pushed a commit
that referenced
this issue
Apr 22, 2020
If we started holding the tool tip down on a surface that accepts tablet v2, we should notify that surface if it gets released over a surface that doesn't support v2. Since GTK supports tablet v2, this fixes the common case of starting a drag over a GTK surface (e.g. scrollbar) and releasing it outside (e.g. over the gaps between sway containers, or in a terminal). Refs #5230.
Xyene
added a commit
to Xyene/sway
that referenced
this issue
Apr 26, 2020
Xyene
added a commit
to Xyene/sway
that referenced
this issue
Apr 26, 2020
d88460f addressed sending v2 tool tip up when over a non-v2 surface. This commit addresses the other direction. Fixes swaywm#5230.
Xyene
added a commit
to Xyene/sway
that referenced
this issue
Apr 26, 2020
d88460f addressed sending v2 tool tip up when over a non-v2 surface. This commit addresses the other direction. Fixes swaywm#5230.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With a mouse, if one does something like press down on a scrollbar and leave the window the scrollbar belongs to, and then release the mouse button, the scrollbar will be released.
If someone does the same with a tablet pen, the scrollbar is not released -- the tablet pen up event is not delivered. If the tablet pen re-enters the window while hovering, not pressed, the window remains under the impression that the pen is still down.
Running with
WAYLAND_DEBUG
shows thatzwp_tablet_tool_v2.proximity_out
is never sent if the pen left the window while the tablet pen is down. It's not sent after it's released in another window, either. Theleave
event is being sent, as is the eventualremoved
when I lift the pen.I've had this happen with every app I've tried (
gedit
, Firefox,kitty
).gedit
actually crashes a short while later inlibwayland-client.so:wl_proxy_marshal
, which I imagine is related as it doesn't happen when not trying to reproduce this issue.I think this has to do with tablet v2 support. If the tablet is released over a surface supporting v2, the surface that is implicitly grabbed isn't notified of
proximity_out
. (For instancekitty
does not support tablet v2, so releasing the pen over akitty
window works correctly, but releasing it over Firefox orgedit
doesn't)The text was updated successfully, but these errors were encountered: