Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mouse_warping container does't take effect when toggling focus between floating and tiled layers #5772

Closed
b0o opened this issue Oct 28, 2020 · 4 comments · Fixed by #5780
Closed
Labels
bug Not working as intended input/pointer

Comments

@b0o
Copy link

b0o commented Oct 28, 2020

Please fill out the following:

  • Sway Version:

    • sway version v1.5
  • Description:

Based on the descriptions of the mouse_warping and focus mode_toggle commands, it would seem to reason that changing container focus via focus mode_toggle should trigger a mouse warp when mouse_warping container is set. Currently, the mouse cursor remains stationary.

mouse_warping output|container|none
  If output is specified, the mouse will be moved to new outputs as you move focus between them. If con‐
  tainer is specified, the mouse will be moved to the middle of the container on switch. Default is out‐
  put.

focus mode_toggle
  Moves focus between the floating and tiled layers.
@b0o b0o added the bug Not working as intended label Oct 28, 2020
@Xyene
Copy link
Member

Xyene commented Oct 28, 2020

Indeed, your understanding is correct. I just tested this, and it seems the conditions necessary to reproduce this issue are that the area of the floating container must overlap with the location on the tiling layer that will be warped to. In that case, the warp will not happen; otherwise, the warp succeeds.

Does this match what you are experiencing?

@b0o
Copy link
Author

b0o commented Oct 28, 2020

I just tested this, and it seems the conditions necessary to reproduce this issue are that the area of the floating container must overlap with the location on the tiling layer that will be warped to

Yes. To be more specific, it seems if the center of the floating window overlaps the container to be focused on the tiling layer, the warp does not happen.

Xyene added a commit to Xyene/sway that referenced this issue Oct 31, 2020
This commit switches focusing behavior to force a warp when executing
`focus mode_toggle`.

Fixes swaywm#5772.
Xyene added a commit to Xyene/sway that referenced this issue Nov 1, 2020
This commit switches focusing behavior to force a warp when executing
`focus mode_toggle`.

Fixes swaywm#5772.
Xyene added a commit to Xyene/sway that referenced this issue Nov 1, 2020
This commit switches focusing behavior to force a warp when executing
`focus mode_toggle`.

Fixes swaywm#5772.
@Xyene
Copy link
Member

Xyene commented Nov 1, 2020

I've submitted #5780 to address this, if you'd like to give it a try.

Xyene added a commit to Xyene/sway that referenced this issue Nov 1, 2020
This commit switches focusing behavior to force a warp when executing
`focus mode_toggle`.

Fixes swaywm#5772.
Xyene added a commit to Xyene/sway that referenced this issue Nov 1, 2020
This commit switches focusing behavior to force a warp when executing
`focus mode_toggle`.

Fixes swaywm#5772.
Xyene added a commit to Xyene/sway that referenced this issue Nov 1, 2020
This commit switches focusing behavior to force a warp when executing
`focus mode_toggle`.

Fixes swaywm#5772.
RedSoxFan pushed a commit that referenced this issue Nov 1, 2020
This commit switches focusing behavior to force a warp when executing
`focus mode_toggle`.

Fixes #5772.
@b0o
Copy link
Author

b0o commented Nov 2, 2020

@Xyene Thank you! I haven't had a chance to test it personally yet, will do so soon. Glad to see it's merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Not working as intended input/pointer
Development

Successfully merging a pull request may close this issue.

2 participants