Weird dialog windows

[jarias]

Some dialog windows don't show as floating windows others appear too small to be used or resize.

Arch Linux
Sway 0.5-2
wlc 0.0.2-1
xwayland 1.18.3-1

In this example the small black square is the dialog window it appears floating but the size is useless, can't even resize it.

[johnp]

Workaround for the probably Java-related case (happens to me in Jetbrains IDEs, JDownloader, Cisco ASDM): Select floating fragment and change to fullscreen. Won't be able to switch back though. Would be interesting if setting some minimum size for floating windows in case their dimensions can't be inferred helps.

debug log excerpt:

[handlers.c:210] handle:5 type:8 state:0 parent:4 mask:0 (x:740 y:383 w:1 h:1) title:Add Per-Session NAT Rule class:sun-awt-X11-XDialogPeer appid:(null)
[container.c:299] Adding new view 5:8:Add Per-Session NAT Rule as a floating view
[debug_log.c:96] Setting focus to 0x1f70400:5 (VIEW 'Add Per-Session NAT Rule')
[debug_log.c:96] Arranging layout for 0x1f433d0 (OUTPUT 'eDP-1')
[layout.c:711] Arranging layout for 0x1f433d0 eDP-1 1920.000000x1080.000000+0.000000,0.000000
[debug_log.c:96] Arranging layout for 0x1f434c0 (WORKSPACE '1')
[layout.c:711] Arranging layout for 0x1f434c0 1 1920.000000x1059.000000+0.000000,0.000000
[layout.c:750] -> Found panel for this workspace: 1920x21, position: 1
[layout.c:772] Arranging workspace '1' at 0.000000, 0.000000
[layout.c:840] Arranging 0x1f434c0 horizontally
[layout.c:844] Calculating arrangement for 0x178b990:4 (will scale 1920.000000 by 1.000000)
[layout.c:711] Arranging layout for 0x178b990 johnp@johnp-laptop: ~ 1920.000000x1059.000000+0.000000,0.000000
[layout.c:782] Set view to 1920 x 1059 @ 0, 0
[debug_log.c:96] Arranging layout for 0x19f6eb0 (WORKSPACE '2')
[layout.c:711] Arranging layout for 0x19f6eb0 2 1920.000000x1059.000000+0.000000,0.000000
[layout.c:750] -> Found panel for this workspace: 1920x21, position: 1
[layout.c:772] Arranging workspace '2' at 0.000000, 0.000000
[layout.c:840] Arranging 0x19f6eb0 horizontally
[layout.c:844] Calculating arrangement for 0x1f6cc50:4 (will scale 1920.000000 by 1.000000)
[layout.c:711] Arranging layout for 0x1f6cc50 Cisco ASDM 7.3 for ASA - 192.168.1.10 1920.000000x1059.000000+0.000000,0.000000
[layout.c:782] Set view to 1920 x 1059 @ 0, 0
[layout.c:941] Set floating view to 1 x 1 @ 960, 529
focus:R      |(0x633400)(p:(nil)   )(f:0x1f433d0)(h:18446744073709551615)Type:root|layout:-    |w:   0|h:   0|x:   0|y:   0|g:  0|vis:t|children: 1|name:(null)
|focus:X     |(0x1f433d0)(p:0x633400)(f:0x19f6eb0)(h: 1)Type:op  |layout:-    |w:1920|h:1080|x:   0|y:   0|g: -1|vis:t|children: 2|name:eDP-1
|-focus:X    |(0x1f434c0)(p:0x1f433d0)(f:0x178b990)(h:18446744073709551615)Type:ws  |layout:Horiz|w:1920|h:1059|x:   0|y:   0|g: -1|vis:f|children: 1|name:1
|--focus:X   |(0x178b990)(p:0x1f434c0)(f:(nil)   )(h: 2)Type:view|layout:-    |w:1920|h:1059|x:   0|y:   0|g: -1|vis:f|children: 0|name:johnp@johnp-lapt
|-focus:W    |(0x19f6eb0)(p:0x1f433d0)(f:0x1f70400)(h:18446744073709551615)Type:ws  |layout:Horiz|w:1920|h:1059|x:   0|y:   0|g: -1|vis:t|children: 1|name:2
|--focus:X   |(0x1f6cc50)(p:0x19f6eb0)(f:(nil)   )(h: 4)Type:view|layout:-    |w:1920|h:1059|x:   0|y:   0|g: -1|vis:t|children: 0|name:Cisco ASDM 7.3 f
|==focus:K   |(0x1f70400)(p:0x19f6eb0)(f:(nil)   )(h: 5)Type:view|layout:-    |w:   1|h:   1|x: 960|y: 529|g: -1|vis:t|children: 0|name:Add Per-Session

If wlc gets bogus dimensions (0x0), shouldn't that probably be handled more gracefully than just setting dimensions to 1x1?

Cloudef/wlc@d17a9f4
https://github.com/Cloudef/wlc/blob/390bdb0f3ea1767316a94a7db516e77c35fe2874/src/compositor/view.c#L212
https://github.com/Cloudef/wlc/blob/390bdb0f3ea1767316a94a7db516e77c35fe2874/src/compositor/view.c#L240

[ddevault]

Does #691 fix this for you?

[jarias]

@SirCmpwn would test that out as soon as I can.

[jarias]

@SirCmpwn It work for the minimum size now at least its usable not great cause manual resize is till needed but at least I can resize it now, but for the libreoffice example still works the same way the dialog is not floated and not clickable either

[ddevault]

Yeah I figured LO wouldn't be helped but I'm glad to hear the other one is better.