Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab dragging functionality #6218

Closed
tomKPZ opened this issue Apr 23, 2021 · 2 comments
Closed

Tab dragging functionality #6218

tomKPZ opened this issue Apr 23, 2021 · 2 comments
Labels
enhancement New feature or incremental improvement

Comments

@tomKPZ
Copy link
Contributor

tomKPZ commented Apr 23, 2021

Tab dragging is an intuitive, well understood functionality implemented by VScode [1], Chrome, Firefox, etc. Sway currently allows detaching tabs by dragging them, but cannot join the tab to an existing tab or stack container.

I've implemented this behavior with a patch [2] and I'll open a PR shortly.

[1] https://user-images.githubusercontent.com/9124077/115812431-3ab87d80-a3a6-11eb-9f2b-e31525d75857.mp4
[2] https://user-images.githubusercontent.com/9124077/115812402-2bd1cb00-a3a6-11eb-8868-ad9db6185095.mp4

@tomKPZ tomKPZ added the enhancement New feature or incremental improvement label Apr 23, 2021
tomKPZ added a commit to tomKPZ/sway that referenced this issue Apr 23, 2021
Implements functionality described in [1].  Please see the issue for a
video with a demonstration of the new behavior.

An issue is that titlebars cover up a significant portion of the top
edge drop area.  The solution is simply to change the edge drop area
hitbox to start at the contents instead of the container.

[1] swaywm#6218
tomKPZ added a commit to tomKPZ/sway that referenced this issue Apr 25, 2021
Implements functionality described in [1].  Please see the issue for a
video with a demonstration of the new behavior.

An issue is that titlebars cover up a significant portion of the top
edge drop area.  The solution is simply to change the edge drop area
hitbox to start at the contents instead of the container.

[1] swaywm#6218
tomKPZ added a commit to tomKPZ/sway that referenced this issue May 2, 2021
Implements functionality described in [1].  Please see the issue for a
video with a demonstration of the new behavior.

An issue is that titlebars cover up a significant portion of the top
edge drop area.  The solution is simply to change the edge drop area
hitbox to start at the contents instead of the container.

[1] swaywm#6218
@Ashe
Copy link

Ashe commented May 5, 2021

Really looking forward to this getting implemented, I miss this from i3!

Xyene pushed a commit that referenced this issue May 6, 2021
Implements functionality described in [1].  Please see the issue for a
video with a demonstration of the new behavior.

An issue is that titlebars cover up a significant portion of the top
edge drop area.  The solution is simply to change the edge drop area
hitbox to start at the contents instead of the container.

[1] #6218
@emersion
Copy link
Member

emersion commented May 7, 2021

Implemented in #6219

@emersion emersion closed this as completed May 7, 2021
RagnarGrootKoerkamp pushed a commit to RagnarGrootKoerkamp/sway that referenced this issue Jun 17, 2021
Implements functionality described in [1].  Please see the issue for a
video with a demonstration of the new behavior.

An issue is that titlebars cover up a significant portion of the top
edge drop area.  The solution is simply to change the edge drop area
hitbox to start at the contents instead of the container.

[1] swaywm#6218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or incremental improvement
Development

No branches or pull requests

3 participants