Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement wlr-foreign-toplevel request_minimize event #6457

Open
LBCrion opened this issue Aug 22, 2021 · 10 comments
Open

Implement wlr-foreign-toplevel request_minimize event #6457

LBCrion opened this issue Aug 22, 2021 · 10 comments
Labels
enhancement New feature or incremental improvement

Comments

@LBCrion
Copy link

LBCrion commented Aug 22, 2021

i3 does not have a concept of a minimized window, but users commonly treat scratchpad as a viable alternative to minimization. To keep with i3 standards, can we implement wlr-foreign-toplevel minimize request as move to and from scratchpad? This approach keeps with i3 functionality and provides a more complete implementation of the foreign toplevel protocol.

@LBCrion LBCrion added the enhancement New feature or incremental improvement label Aug 22, 2021
@LBCrion
Copy link
Author

LBCrion commented Aug 22, 2021

A simple patch vs 1.6.1 to implement this functionality:
sway-wlr-foreign-toplevel-minimize.txt

@emersion
Copy link
Member

We don't do anything on xdg-shell request_minimize. Marking a window as minimized through wlr-foreign-toplevel would make things inconsistent.

@LBCrion
Copy link
Author

LBCrion commented Aug 22, 2021

I'm not suggesting marking the window as minimized. Just moving it to scratchpad. The implementation just provides applications (taskbars most likely) with a wayland interface to move windows to and from scratchpad.

@emersion
Copy link
Member

i3 doesn't do it, so I don't think we should.

@emersion
Copy link
Member

For reference, i3 discussion about this: i3/i3#1457

bi4k8 pushed a commit to bi4k8/sway that referenced this issue Sep 29, 2021
@WillPower3309
Copy link

While I generally agree that sway should stick to the way i3 handles things, we may want to make an exception here considering the current implementation can crash sway under certain circumstances, as described in #5977

@WillPower3309
Copy link

I would also ask what the purpose of the scratchpad is if not to act as a minimize?

@emersion
Copy link
Member

The crash can be fixed. It's orthogonal to the proposal described in this issue.

@Iss-in
Copy link

Iss-in commented May 2, 2022

I would also ask what the purpose of the scratchpad is if not to act as a minimize?

yes exact;y, its an awesome functionality that is hindered by treating it as something that is not minimized. usecase involving swiftly hiding/unhiding background floating apps like pomodoro and sticky notes via taskbar

@emersion pls look into it, it really brings a lot of convenience here

@WhyNotHugo
Copy link
Contributor

I would also ask what the purpose of the scratchpad is if not to act as a minimize?

I mounted something via sshfs on a shell, and want the terminal window out of the way forever -> stratchpad.

The scratchpad is not really an equivalent to minimisation; windows sent to the scratchpad lose their workspace too. Usually, minimised windows remain on that workspace and are not accessible on other workspaces. The semantics don't really match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or incremental improvement
Development

No branches or pull requests

5 participants