Focus v2 #65
Merged
Focus v2 #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!checkarg(argc, "floating_modifier", EXPECTED_EQUAL_TO, 1)) { | ||
| return false; | ||
| } | ||
| config->floating_mod = xkb_keysym_from_name(argv[0], XKB_KEYSYM_CASE_INSENSITIVE); |
There was a problem hiding this comment.
Note that this won't work for modifier keys. Look at bindsym, it has to deal with them special. Not going to block this pull request because of it, though.
There was a problem hiding this comment.
I don't think it should, I changed some code a while back that made is so that varsubs are done on all parts of every command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
focus is better handled now.
there is
container focuswhich is the current container sway is focused on.there is
view focuswhich is the container that should receive keyboard input.other then that they are pretty similar, and in most cases the same.
focus_viewhas been replaced withset_container_focusfocus_pointerhas been replaced withset_container_focus(container_under_pointer())movement.[ch]has been renamed tofocus.[ch]with some extra functions added.handling views by their type is still pretty off, so we need to do more work on that. but for now
dmenu/rightclick/firefox popups all work as they should.
merged @Luminarys resizing code into this.
though it seems to need some work. the windows are quite floaty.