Variables related fixes #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix the corner case where a variable is not assigned, but used anyway. This should solve partially the issue swaywm#681.
…les_corner_cases
| @@ -2152,6 +2152,10 @@ static struct cmd_results *cmd_set(int argc, char **argv) { | |||
| return error; | |||
| } | |||
|
|
|||
| if (argv[0][0] != '$') { | |||
| return cmd_results_new(CMD_FAILURE, "set", "Malformed variable assignment, name has to start with $"); | |||
| } | |||
|
I would rather add the $ for them than raise an error. |
…into variables_corner_cases
|
From what I understood from the i3 code this is the default behavior, it only raises an error. |
|
I think it would be better, yes. Log a warning though. |
|
@SirCmpwn is it ok now? Or do you need any modification to merge this? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the check of the $ for the variable assigned.
So set something /home generates an error, since the correct syntax must be set $something /home.
This also should fix partially the issue #681 since now it handles the undefined behavior of p.we_wordv.