Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dmabuf-feedback duplicates implicit modifiers #7028

Closed
columbarius opened this issue May 26, 2022 · 3 comments
Closed

Dmabuf-feedback duplicates implicit modifiers #7028

columbarius opened this issue May 26, 2022 · 3 comments
Labels
bug Not working as intended

Comments

@columbarius
Copy link
Contributor

@columbarius columbarius added the bug Not working as intended label May 26, 2022
@emersion
Copy link
Member

This should help: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3570

@bl4ckb0ne
Copy link
Contributor

The patch has been merge, please try sway + wlroots master to see if the issue is still present.

udfn pushed a commit to udfn/wlroots that referenced this issue May 29, 2022
@emersion @bl4ckb0ne
linux-dmabuf-v1: fix MOD_INVALID handling in feedback tranches
4d7f1ae 
[1] has changed wlr_drm_format to remove the assumption that
MOD_INVALID is always implicitly enabled. MOD_INVALID is now part
of the modifier list just like any other modifier.

The patch adding support for linux-dmabuf-v1 feedback has been
written a lot of time before [1], and hasn't been updated accordingly
when merged. This results in MOD_INVALID being advertised twice [2] and
other index bugs.

Fix these issues by removing special-casing for MOD_INVALID.

[1]: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3231
[2]: swaywm/sway#7028
@columbarius
Copy link
Contributor Author

Tested sway + wlroots master. No duplicated modifiers anymore. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Not working as intended
Milestone
No milestone
Development

No branches or pull requests
3 participants
@emersion @bl4ckb0ne @columbarius