sway-1.9_rc1 fails to build when wlroots built without drm #7943
Labels
bug
Not working as intended
Comments
|
At least got @t-dr unblocked for testing's sake on IRC, but given this is the first reference to Was told to post the patch for reference though, so here ya go diff --git a/include/sway/server.h b/include/sway/server.h
index adb62cda..afd92de9 100644
--- a/include/sway/server.h
+++ b/include/sway/server.h
@@ -3,13 +3,16 @@
#include <stdbool.h>
#include <wayland-server-core.h>
#include <wlr/backend.h>
+#include <wlr/config.h>
#include <wlr/render/allocator.h>
#include <wlr/render/wlr_renderer.h>
#include <wlr/types/wlr_compositor.h>
#include <wlr/types/wlr_data_device.h>
#include <wlr/types/wlr_input_method_v2.h>
#include <wlr/types/wlr_foreign_toplevel_management_v1.h>
+#if WLR_HAS_DRM_BACKEND
#include <wlr/types/wlr_drm_lease_v1.h>
+#endif
#include <wlr/types/wlr_layer_shell_v1.h>
#include <wlr/types/wlr_output_management_v1.h>
#include <wlr/types/wlr_output_power_management_v1.h>
@@ -91,8 +94,10 @@ struct sway_server {
struct wl_listener xdg_decoration;
struct wl_list xdg_decorations; // sway_xdg_decoration::link
+#if WLR_HAS_DRM_BACKEND
struct wlr_drm_lease_v1_manager *drm_lease_manager;
struct wl_listener drm_lease_request;
+#endif
struct wlr_pointer_constraints_v1 *pointer_constraints;
struct wl_listener pointer_constraint; |
|
Successfully built with the patch after rebuilding wlroots without its drm support enabled Build log attached from the successful build |
|
@mcoffin could you open a PR with your patch please? thank you for fixing the issue |
|
@t-dr I think it was your patch, mind making a PR? |
emersion
added a commit
to emersion/sway
that referenced
this issue
Feb 15, 2024
The header is not installed by wlroots when the DRM backend is disabled. We don't need it here, so don't include it. Closes: swaywm#7943
bl4ckb0ne
pushed a commit
that referenced
this issue
Feb 15, 2024
The header is not installed by wlroots when the DRM backend is disabled. We don't need it here, so don't include it. Closes: #7943
|
I seem to get a similar issue, see my log: I am on kernel |
udfn
pushed a commit
to udfn/sway
that referenced
this issue
Feb 21, 2024
The header is not installed by wlroots when the DRM backend is disabled. We don't need it here, so don't include it. Closes: swaywm#7943
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Sway Version:
swaymsg -t get_versionorsway -vDebug Log:
Configuration File:
Stack Trace:
Description:
Compiling sway-1.9_rc1 fails if wlroots has drm enabled
wlroots info:
gui-libs/wlroots-0.17.1
built without: drm libinput -liftoff session tinywl X x11-backend xcb-errors
built with: libinput session vulkan
Re-enabling drm on wlroot allows sway-1.9_rc1 to build successfully
Build log from failure attached.
sway-1.9_rc1-build.log
This was found building on gentoo linux where drm had been masked on wlroot
#sway suggesting opening an issue so it's not lost/dropped
The text was updated successfully, but these errors were encountered: