i3 feature support: Moving flotaing containers #1092
Conversation
|
I know that sway does not use macros, but I saw that |
|
Macros defined by standard headers are fine. |
sway/commands/move.c
Outdated
| "'move <container|window> to workspace <name>' or " | ||
| "'move <container|window|workspace> to output <name|direction>' or " | ||
| "'move position mouse'"; | ||
| swayc_t *view = get_focused_container(&root_container); | ||
|
|
||
| if (argc == 3 && strcasecmp(argv[2], "px") == 0 ) { | ||
| move_len = (int)strtol(argv[1], NULL, 10); |
There was a problem hiding this comment.
I would prefer to call this move_amt. Not really a length.
|
Does i3 support |
|
How about |
sway/sway.5.txt
Outdated
| or _next_ swaps the container with its sibling in the same container. Move | ||
| _first_ exchanges the focused element in an auto layout with the first | ||
| element, i.e. promotes the focused element to master position. | ||
| **move** <left|right|up|down|next|prev|first> <[px] px>:: |
There was a problem hiding this comment.
Since move prev et al don't work with pixel arguments, split them into a separate doc thing.
|
Yes, i3 allows both |
sway/sway.5.txt
Outdated
| element, i.e. promotes the focused element to master position. | ||
| **move** <left|right|up|down> <[px] px>:: | ||
| Moves the focused container _left_, _right_, _up_, or _down_. If the window | ||
| is floating it moves it _px_ in that direction. |
There was a problem hiding this comment.
Can you clarify that px is optional and changes the behavior? Maybe this should be split again into two sections. Current version is unclear about the distinction between move left and move left 10px
There was a problem hiding this comment.
Sure, I can see how this needs clarification. Both move left and move left 10px affect both floating and tiled containers. Why should they be split into different sections?
There was a problem hiding this comment.
Just proposing that two sections might make sense. If you can sufficiently clarify it without that's fine.
This commit lets the 'move' command apply to floating containers as well as tiled ones. The command may be appended with a number of pixels and then optionally the string `px` (like '10 px') in order to move the container more or fewer than the standard ten pixels.
|
Thanks! |
This commit lets the 'move' command apply to floating containers as well
as tiled ones. The command may be appended with a number of pixels and
then the string
px(like '10 px') in order to move the container moreor fewer than the standard ten pixels.