Fix #1099: Allow spaces in worspace names #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows unquoted spaces in worspace names in order to keep compatability with i3. The names _must not_ contain the string "output" which is documented in 'sway.5' because how sway detects the `move <workspace> output <output>` command. Also I documented that "number" may be used before the worspace name without affecting how the name is evaluated.
|
Does the "output" limitation match i3? |
|
I'm not sure. I can't find anything in the docs (relavent section here?) except that spaces are allowed in workspace names. I'm not quite sure how else to handle "output" other then this except for allowing spaces in one command and not another. |
|
Well, w/e. It probably works for most cases. We can change it if someone complains about some incompatability later on. |
|
Thanks! |
|
Thanks! 🎉 |
ddevault
added a commit
that referenced
this pull request
Mar 7, 2017
Fix #1099: Allow spaces in worspace names
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows unquoted spaces in worspace names in order to keep
compatability with i3. The names must not contain the string "output"
which is documented in 'sway.5' because how sway detects the
move <workspace> output <output>command. Also I documented that "number"may be used before the worspace name without affecting how the name is
evaluated.