Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libcap check to CMake #1150

Merged
merged 1 commit into from
Apr 8, 2017
Merged

Conversation

JerziKaminsky
Copy link
Contributor

@JerziKaminsky JerziKaminsky commented Apr 6, 2017

  • Moved <sys/capability.h> include inside __linux__ guard, because all uses are similarly guarded.
  • <sys/capability.h> is a part of optional devel package on at least fedora, so CMake now explicitly checks that libcap devel files are available.
  • Added libcap to list of arch packages in .travis.yml, to make the dependency explicit. travis-ci installs the package by default, which is why this hasn't surfaced previously).

@JerziKaminsky JerziKaminsky changed the title Add libcap check to CMake WIP: Add libcap check to CMake Apr 6, 2017
@JerziKaminsky JerziKaminsky force-pushed the cmake_find_libcap branch 4 times, most recently from 6b31d2a to 91557f3 Compare April 6, 2017 23:56
@JerziKaminsky JerziKaminsky changed the title WIP: Add libcap check to CMake Add libcap check to CMake Apr 7, 2017
@JerziKaminsky JerziKaminsky force-pushed the cmake_find_libcap branch 2 times, most recently from 40d2485 to ee3ca32 Compare April 7, 2017 00:05
- Moved ``<sys/capability.h>`` include inside `__linux__` guard,
  because all uses are similarly guarded.
- <sys/capability.h> is part of an optional devel package, at least
  in fedora. CMake now explicitly checks that libcap devel files
  are available.
- Added libcap to the list of install packages in .travis.yml, to
  make the dependency explicit. travis-ci installs the package by
  default, which is why this hasn't surfaced previously.
@JerziKaminsky JerziKaminsky force-pushed the cmake_find_libcap branch 2 times, most recently from 632311a to aa6bd85 Compare April 7, 2017 00:14
@ddevault ddevault merged commit 7fee555 into swaywm:master Apr 8, 2017
@ddevault
Copy link
Contributor

ddevault commented Apr 8, 2017

Thanks!

@JerziKaminsky JerziKaminsky deleted the cmake_find_libcap branch April 9, 2017 00:28
@JerziKaminsky JerziKaminsky mentioned this pull request Apr 14, 2017
@ddevault ddevault mentioned this pull request Apr 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants