-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for manually setting subpixel hinting on outputs. #3645
Conversation
Other points:
|
2307a0b
to
c74f9b1
Compare
Also just as a note, since sway is currently in a feature freeze for the 1.0 tree, this will not make it into 1.0. |
6230211
to
ade1fdf
Compare
I can also change the subpixel hinting at runtime with |
ade1fdf
to
062e733
Compare
drmModeConnector.subpixel doesn't seem to detect subpixel order on many displays (especially laptops). Allow subpixel order to be manually set. The corresponding PR for sway adds a subpixel output option: swaywm/sway#3645 Once both are merged, swaywm/sway#3163 will be fixed.
062e733
to
3a43dc8
Compare
drmModeConnector.subpixel doesn't seem to detect subpixel order on many displays (especially laptops). Allow subpixel order to be manually set. The corresponding PR for sway adds a subpixel output option: swaywm/sway#3645 Once both are merged, swaywm/sway#3163 will be fixed.
9db8fee
to
78427f1
Compare
df1fc6b
to
ebec8b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still needs a way for the value to reset subpixel on reload. Currently, it sets WL_OUTPUT_SUBPIXEL_UNKNOWN
as part of the default output config, but apply_output_config
does not call wlr_output_set_subpixel
for WL_OUTPUT_SUBPIXEL_UNKNOWN
. Ideally, it would reset to the value it had before any manual changes
ebec8b1
to
1c35f1d
Compare
Alright. I added the code to store the original subpixel value & reset it in |
1c35f1d
to
dd729d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the most part this LGTM. I personally can't tell a difference, but I'll take your word for it that it changes. Can you just make the few small changes and squash the commits together?
dd729d4
to
2576de1
Compare
2576de1
to
e102f1f
Compare
Alright, changes made. Before merging, I want to test this again on a lower resolution display to make sure it still behaves correctly. I'm busy for the rest of the day, so it might be as late as tomorrow before I know for sure. |
e102f1f
to
325c5d8
Compare
985d4e9
to
db939f7
Compare
Many laptop screens report unknown subpixel order. Allow users to manually set subpixel hinting to work around this. Addresses swaywm#3163
Thanks! |
Many laptop screens report unknown subpixel order. Allow users to manually set subpixel hinting to work around this.
Addresses #3163
TODO: update docs.