Fix output manager segfault #4673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apply_output_config would call output_enable and always return true, even if the output couldn't be enabled.
Calling wlr_output_manager_v1_set_configuration with an enabled output and a NULL mode is incorrect if the output doesn't support modes. When DPMS'ing an output, wlr_output_enable(output, false) is called. This de-allocates the CRTC and sets wlr_output.current_mode to NULL. Because we mark DPMS'ed outputs as enabled, we also need to provide a correct output mode. Add a field to sway_output to hold the current mode. Closes: swaywm/wlroots#1867
emersion
added a commit
to emersion/wlroots
that referenced
this pull request
Oct 26, 2019
Makes it easier to figure out when the compositor submits an invalid output state. References: swaywm/sway#4673
ddevault
pushed a commit
to swaywm/wlroots
that referenced
this pull request
Oct 27, 2019
Makes it easier to figure out when the compositor submits an invalid output state. References: swaywm/sway#4673
ddevault
approved these changes
Oct 27, 2019
|
Thanks! |
aiqs4
pushed a commit
to aiqs4/wlroots
that referenced
this pull request
Dec 19, 2019
Makes it easier to figure out when the compositor submits an invalid output state. References: swaywm/sway#4673
aiqs4
pushed a commit
to aiqs4/wlroots
that referenced
this pull request
Dec 19, 2019
Makes it easier to figure out when the compositor submits an invalid output state. References: swaywm/sway#4673
aiqs4
pushed a commit
to aiqs4/wlroots
that referenced
this pull request
Dec 19, 2019
Makes it easier to figure out when the compositor submits an invalid output state. References: swaywm/sway#4673
aiqs4
pushed a commit
to aiqs4/wlroots
that referenced
this pull request
Dec 19, 2019
Makes it easier to figure out when the compositor submits an invalid output state. References: swaywm/sway#4673
aiqs4
pushed a commit
to aiqs4/wlroots
that referenced
this pull request
Dec 19, 2019
Makes it easier to figure out when the compositor submits an invalid output state. References: swaywm/sway#4673
filips
pushed a commit
to filips/wlroots
that referenced
this pull request
Mar 15, 2020
Makes it easier to figure out when the compositor submits an invalid output state. References: swaywm/sway#4673
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit messages.
Closes: swaywm/wlroots#1867