input/cursor: don't send wl_pointer.motion event on pointer unlock warp #5431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, this writes into the internal seat state. I wonder if there's a better way to do this… |
|
Yeah, I'm not a huge fan of poking into wlroots like this either. The fundamental problem is we do seem to need to be able to change that state without notifying clients of motion events (for this and #5459, at least), but knowledge of that state existing breaks the abstraction (as far as I can tell, it's just there as an optimization to prevent sending duplicate motion events). Perhaps we could add |
emersion
reviewed
Jun 30, 2020
|
+1 to |
Xyene
added a commit
to Xyene/wlroots
that referenced
this pull request
Jul 3, 2020
These allow a compositor to do things like skip motion events on pointer constraint unlock, or not move the pointer during touch emulation. Refs swaywm/sway#5431, swaywm/sway#5459.
Xyene
force-pushed
the
no-motion-event-on-constraint-unlock
branch
from
280669d
to
050c79e
Compare
emersion
pushed a commit
to swaywm/wlroots
that referenced
this pull request
Jul 15, 2020
It allows a compositor to do things like skip motion events on pointer constraint unlock. References: swaywm/sway#5431
emersion
force-pushed
the
no-motion-event-on-constraint-unlock
branch
from
050c79e
to
71cad7b
Compare
On warping to a cursor hint, update the pointer position we track as well, so that on the next pointer rebase we don't send an unexpected synthetic motion event to clients. Fixes swaywm#5405.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On warping to a cursor hint, update the pointer position we track as well, so that on the next pointer rebase we don't send an unexpected synthetic motion event to clients.
Fixes #5405.
Refs https://gitlab.freedesktop.org/wayland/wayland-protocols/-/issues/20, awaiting clarification on that end but figured I should bring up a patch for testing/review earlier. I don't have any games/applications that require this patch, so it hasn't been tested by me (hoping to get someone affected by the issue to give it a shot).
If the plan is to tag Sway 1.5 in the near-ish future, I think we should either (temporarily) revert 6ea4539 or apply something along the lines of this patch. The slight cosmetic improvement 6ea4539 provides (+ making clicks post-
swaymsg cursor moveclick the right location) is probably not worth breaking applications that rely on not seeing a motion event post-unlock.(Tacking onto 1.5 milestone so that it doesn't get lost.)