Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing transaction commits to seatop_default #6035

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

David96
Copy link
Contributor

@David96 David96 commented Feb 16, 2021

See commit description.

I hope I didn't miss anything.

Every seat_set_focus* should be followed by a transaction_commit_dirty.
In cases where the focus change is followed by a seatop_begin* this is
not needed, as transaction_commit_dirty is then called by the
seatop_begin* function.

Fixes swaywm#6034
Copy link
Member

@kennylevinsen kennylevinsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test if it solved #6034?

LGTM, /cc @Xyene.

@David96
Copy link
Contributor Author

David96 commented Feb 16, 2021

Yes, the last transaction_commit_dirty added fixes that.

Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@Xyene Xyene merged commit 28cadf5 into swaywm:master Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants