Destroy Sway subsurfaces when destroying Sway layer_surface #6421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise destroying wlr_layer_surface could destroy sway_layer_surface before destroying its subsurfaces that would try to access the sway_layer_surface regardless, possibly crashing Sway.
emersion
reviewed
Aug 5, 2021
| @@ -47,6 +51,7 @@ struct sway_layer_subsurface { | |||
| struct wl_listener unmap; | |||
| struct wl_listener destroy; | |||
| struct wl_listener commit; | |||
| struct wl_listener surface_destroy; | |||
There was a problem hiding this comment.
Instead of setting up an event listener, can we just iterate over the layer sub-surfaces and destroy them in handle_destroy?
There was a problem hiding this comment.
Probably. I did it this way only because everything else here seems to work this way. What you suggest is probably better.
There was a problem hiding this comment.
The rest of the event listeners are listening to wlroots events. wlroots doesn't know about Sway, so we need this complexity in the wlroots API.
However for Sway-internal stuff we shouldn't need it.
|
Superseded by #6728 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to fix #6337