Bump RLIMIT_NOFILE #6629
Merged
Bump RLIMIT_NOFILE #6629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wayland compositors handle many file descriptors: client connections, DMA-BUFs, sync_files, wl_data_device pipes, and so on. Bump the limit to the max. Closes: swaywm#6285
WhyNotHugo
approved these changes
Oct 30, 2021
There was a problem hiding this comment.
I'm running sway with this patch, and can no longer reproduce #6642.
Without this patch and the with my usual amount of windows (just restoring my Firefox session), this reproduces 100% of the times.
With this patch and more-than-usual amount of windows, the issue is no longer reproduced (I did 4 attempts).
|
Thanks! |
|
We should probably also log the nofile limit when setrlimit succeeds. The user might still have a low hard limit. |
|
Showing an error when the limit is reached might be a good idea. Someone mentioned it's handled in a dependency/library, but I can't find the reference to that. |
This was referenced Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wayland compositors handle many file descriptors: client
connections, DMA-BUFs, sync_files, wl_data_device pipes, and so
on. Bump the limit to the max.
Closes: #6285