Follow up wlroots input device field cleanup #6877
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
bl4ckb0ne
force-pushed
the
wlroots-input-device-field-cleanup
branch
2 times, most recently
from
b6d18f9
to
84c0368
Compare
vyivel
reviewed
Mar 17, 2022
sway/input/seat.c
Outdated
| @@ -725,14 +726,25 @@ static void seat_apply_input_config(struct sway_seat *seat, | |||
| ic == NULL ? MAPPED_TO_DEFAULT : ic->mapped_to; | |||
|
|
|||
| switch (mapped_to) { | |||
| case MAPPED_TO_DEFAULT: | |||
| case MAPPED_TO_DEFAULT:; | |||
| /* | |||
| * If the wlroots backend provides an output name, use that. | |||
| * | |||
| * Otherwise, try to map built-in touch and tablet tool devices to the | |||
emersion
reviewed
Mar 17, 2022
| case WLR_INPUT_DEVICE_TOUCH: | ||
| mapped_to_output = dev->touch->output_name; | ||
| break; | ||
| default: |
There was a problem hiding this comment.
This is missing a case for tablet tool devices.
There was a problem hiding this comment.
Ah, I guess we don't actually have an output_name field for these yet?
There was a problem hiding this comment.
Nope, only tablet and pointer.
bl4ckb0ne
force-pushed
the
wlroots-input-device-field-cleanup
branch
from
84c0368
to
d582669
Compare
bl4ckb0ne
force-pushed
the
wlroots-input-device-field-cleanup
branch
from
f10c031
to
054515b
Compare
|
Closed in favour of #6896 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref 1