Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fullscreen crash & build break #7437

Closed
wants to merge 1 commit into from
Closed

Fix fullscreen crash & build break #7437

wants to merge 1 commit into from

Conversation

BBaoVanC
Copy link

@BBaoVanC BBaoVanC commented Feb 7, 2023

Fixes #7436

deprecated-dot
deprecated-dot reviewed Feb 7, 2023
View reviewed changes
Copy link

@deprecated-dot deprecated-dot left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch fixes the build breakage.

Edit: patch also fixes fullscreen crashes. All I tested was youtube in qutebrowser, previously it would crash to prompt immediately upon toggling fullscreen, but now it works as it should.

@emersion
Copy link
Member

emersion commented Feb 7, 2023

A new API was introduced in wlroots!3933: wlr_linux_dmabuf_feedback_v1_init_with_options(). Can we use this instead of manually building the array? This should simplify significantly the code here.

emersion added a commit to emersion/sway that referenced this pull request Feb 7, 2023
@emersion
Use wlr_linux_dmabuf_feedback_v1_init_with_options()
9573a60 
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3933
Closes: swaywm#7436
Closes: swaywm#7437
@emersion emersion mentioned this pull request Feb 7, 2023
Merged
@emersion
Copy link
Member

emersion commented Feb 7, 2023

I've done this in #7440.

bl4ckb0ne pushed a commit that referenced this pull request Feb 7, 2023
@emersion @bl4ckb0ne
Use wlr_linux_dmabuf_feedback_v1_init_with_options()
b4ce0a3 
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3933
Closes: #7436
Closes: #7437
@emersion
Copy link
Member

emersion commented Feb 7, 2023

Thanks for submitting a patch anyways @BBaoVanC!

yuiiio pushed a commit to yuiiio/sway that referenced this pull request Feb 7, 2023
@emersion @yuiiio
Use wlr_linux_dmabuf_feedback_v1_init_with_options()
9ba0878 
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3933
Closes: swaywm#7436
Closes: swaywm#7437
@BBaoVanC BBaoVanC deleted the fix-fullscreen-crash branch February 7, 2023 21:51
@BBaoVanC
Copy link
Author

BBaoVanC commented Feb 7, 2023

I've done this in #7440.

👍 Looks like it works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deprecated-dot deprecated-dot deprecated-dot approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build break
3 participants
@BBaoVanC @emersion @deprecated-dot