Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sway/commands/output: Add command to set color profile #7681
sway/commands/output: Add command to set color profile #7681
Changes from all commits
c785a3b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this interact with HDR? I would assume that ICC is incompatible with HDR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know; I made this PR mainly to test the wlroots MR, and do not know what a good command interface for the long term would look like. Marking this PR as draft until this gets figured out; maybe the answer will be that, like render_bit_depth, this is a short-term approach to be replaced later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a warning that setting a color profile may have odd effects in conjunction with HDR.
Color profiles probably still have a meaningful interpretation even when when the HDR metadata is being sent to a display -- I believe the main difference is that the monitor handles pixel data differently in HDR mode, using absolute luminance, and uses PQ EOTF instead of approximate-sRGB. For example, it should still be possible to use color profiles to correct for monitor miscalibration; or just to apply general color transforms (e.g.: adjusting contrast, making everything brighter, rendering in grayscale, applying hue shifts -- although it might be cleaner to have such color changes be handled with a separate command, using 'Abstract' instead of 'Display' ICC profiles.) Of course, due to the difffering EOTFs being applied by the monitor, any profile used for SDR would produce invalid output for HDR.