-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some build problems #2
Conversation
- Fix dependencies in opam file. - Add missing `-DWLR_USE_UNSTABLE`. Error was: In file included from types_stubgen.c:4: /usr/include/wlr/backend.h:6:2: error: #error "Add -DWLR_USE_UNSTABLE to enable unstable wlroots features" 6 | #error "Add -DWLR_USE_UNSTABLE to enable unstable wlroots features" | ^~~~~ Note: the project still doesn't build, due to other upstream API changes.
Thanks a lot for the PR. As I was mentioning in #3 , note that the project is in a somewhat dormant state right now, but I'll see what I can do for the other build failures today. |
Everything now build in master, and I made some progress on porting the examples (examples/simple.ml is now complete). I do agree that it would be really nice to add CI to the repository, in particular CI triggered on updates in wlroots, so that we know when the bindings become outdated. However I have no experience doing that (or doing CI for ocaml projects in fact). |
I'd suggest:
Alternatively, you could set up Travis with e.g. https://github.com/ocaml/ocaml-ci-scripts/blob/master/README-travis.md - that's more mature, but usually takes much longer to run because it does no caching. |
Thanks! Let's try to use ocaml-ci then. A couple more questions:
|
Yes, you can put For unreleased dependencies, I normally use |
OK, thanks. Just to be clear: what I thought would be useful is that the CI would trigger not only on new commits for the Then I guess the |
(it might be worth noting that AFAIK wlroots/sway has its own CI system, that could be worth using if that is simpler) |
Yes, good point. Probably best to use the same CI as the rest of the project, indeed. |
-DWLR_USE_UNSTABLE
.Error was:
Note: the project still doesn't build, due to other upstream API changes. I don't know how to fix those. Would be good to enable CI for this repository.